Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Support for mounting nvme volumes #56607

Merged
merged 1 commit into from Dec 1, 2017
Merged

AWS: Support for mounting nvme volumes #56607

merged 1 commit into from Dec 1, 2017

Conversation

justinsb
Copy link
Member

Supports mounting nvme volumes

Fixes #56155

AWS: Detect EBS volumes mounted via NVME and mount them

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2017
@justinsb justinsb mentioned this pull request Nov 30, 2017
Closed
@justinsb
Copy link
Member Author

Based on @gnufied 's approach - resolving the symlink

@jsafrane
Copy link
Member

/assign @gnufied
/unassign

@k8s-ci-robot k8s-ci-robot assigned gnufied and unassigned jsafrane Nov 30, 2017
gtaylor
gtaylor reviewed Nov 30, 2017
View reviewed changes
pkg/volume/aws_ebs/aws_util.go Outdated
if err != nil {
glog.Warningf("error mapping volume %q to AWS volume: %v", volumeID, err)
} else {
nvmeName := "nvme-Amazon_Elastic_Block_Store_" + strings.Replace(string(awsVolumeID), "-", "", -1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be worth sticking a comment in here to explain what's going on. It can eventually be inferred by reading on to findNvmeVolume's body, but we could make this more immediately evident.

@justinsb
Copy link
Member Author

Good call @gtaylor - added comments

@gnufied
Copy link
Member

gnufied commented Nov 30, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, justinsb

Associated issue: 56155

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@justinsb justinsb added this to the v1.9 milestone Nov 30, 2017
@justinsb justinsb added sig/aws priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 30, 2017
@justinsb justinsb added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Needs Attention

@gnufied @jingxu97 @justinsb @kubernetes/sig-aws-misc

Action required: During code freeze, pull requests in the milestone should be in progress.
If this pull request is not being actively worked on, please remove it from the milestone.
If it is being worked on, please add the status/in-progress label so it can be tracked with other in-flight pull requests.

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/aws: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit c933067 into kubernetes:master Dec 1, 2017
@justinsb justinsb mentioned this pull request Dec 2, 2017
Merged
justinsb added a commit to justinsb/test-infra that referenced this pull request Dec 2, 2017
@justinsb
Add a test for m5 instances on AWS
bac282a 
M5 intances have nvme and also need the ENA driver.

NVME support: kubernetes/kubernetes#56607
justinsb added a commit to justinsb/test-infra that referenced this pull request Dec 2, 2017
@justinsb
Add a test for m5 instances on AWS
7a7f1af 
M5 intances have nvme and also need the ENA driver.

NVME support: kubernetes/kubernetes#56607
fturib pushed a commit to fturib/test-infra that referenced this pull request Dec 3, 2017
@justinsb
Add a test for m5 instances on AWS
8c7c884 
M5 intances have nvme and also need the ENA driver.

NVME support: kubernetes/kubernetes#56607
@whereisaaron whereisaaron mentioned this pull request Dec 18, 2017
Closed
@dispalt dispalt mentioned this pull request Jan 23, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtaylor gtaylor gtaylor left review comments

Assignees

@gnufied gnufied

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/needs-attention priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@justinsb @jsafrane @gnufied @k8s-github-robot @gtaylor @jingxu97 @k8s-ci-robot