Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deprecation comments to apps/v1beta2 types.go #56867

Merged
merged 2 commits into from Dec 6, 2017
Merged

add deprecation comments to apps/v1beta2 types.go #56867

merged 2 commits into from Dec 6, 2017

Conversation

crimsonfaith91
Copy link
Contributor

@crimsonfaith91 crimsonfaith91 commented Dec 5, 2017 •
edited by janetkuo

What this PR does / why we need it:
This PR adds deprecation comments for apps/v1beta2 statefulset, deployment, replicaset, daemonset, and controller revision in types.go.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56868

Release note:

Deprecates apps/v1beta2 StatefulSet, Deployment, ReplicaSet, DaemonSet, and ControllerRevision.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2017
@kubernetes kubernetes deleted a comment from k8s-github-robot Dec 5, 2017
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2017
@k8s-ci-robot
Copy link
Contributor

@crimsonfaith91: GitHub didn't allow me to assign the following users: liyinan926.

Note that only kubernetes members can be assigned.

In response to this:

/assign @liyinan926
/cc @janetkuo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot assigned janetkuo and unassigned mikedanese and piosz Dec 6, 2017
@k8s-ci-robot
Copy link
Contributor

@crimsonfaith91: GitHub didn't allow me to request PR reviews from the following users: liyinan926.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @liyinan926

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@crimsonfaith91: GitHub didn't allow me to request PR reviews from the following users: liyinan926.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @liyinan926

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@janetkuo janetkuo added this to the v1.9 milestone Dec 6, 2017
@janetkuo
Copy link
Member

janetkuo commented Dec 6, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2017
@janetkuo janetkuo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 6, 2017
@janetkuo
Copy link
Member

janetkuo commented Dec 6, 2017

apps/v1beta2 shouldn't be capitalized. Changed to active voice in the release note.

@janetkuo janetkuo added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Dec 6, 2017
@k8s-github-robot k8s-github-robot removed this from the v1.9 milestone Dec 6, 2017
@crimsonfaith91
Copy link
Contributor Author

crimsonfaith91 commented Dec 6, 2017 •
edited

@janetkuo Thanks for the review and lgtm! :)

@crimsonfaith91
Copy link
Contributor Author

crimsonfaith91 commented Dec 6, 2017 •
edited

@liggitt Do you mind to approve this PR? This PR adds deprecation comment for apps/v1beta2 StatefulSet, Deployment, ReplicaSet, DaemonSet, and ControllerRevision.

@liggitt
Copy link
Member

liggitt commented Dec 6, 2017

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crimsonfaith91, janetkuo, liggitt

Associated issue: #56868

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2017
@liggitt
Copy link
Member

liggitt commented Dec 6, 2017

Are apps/v1beta1 marked deprecated as well?

@liggitt
Copy link
Member

liggitt commented Dec 6, 2017

And to be clear, this doesn't mean we can remove these types/conversions until a migration mechanism is settled on and ensured to be run as part of upgrading

@crimsonfaith91
Copy link
Contributor Author

crimsonfaith91 commented Dec 6, 2017 •
edited

@liggitt apps/v1beta1 has been marked as deprecated 3 months ago via another PR. Yes, we can only remove the codes after 6 months or 2 releases (whichever is longer) based on this policy: https://kubernetes.io/docs/reference/deprecation-policy/

@liggitt
Copy link
Member

liggitt commented Dec 6, 2017

we can only remove the codes after 6 months or 2 releases (whichever is longer) based on this policy

We can't remove the types and conversions until we have migrated all stored instances to newer versions

@crimsonfaith91
Copy link
Contributor Author

We can't remove the types and conversions until we have migrated all stored instances to newer versions

Got it! Thanks for the clarification!

@crimsonfaith91
Copy link
Contributor Author

@janetkuo @liggitt
Do you mind to add priority/critical-urgent label to this PR? I am not able to do so. Thanks!

@liggitt liggitt added this to the v1.9 milestone Dec 6, 2017
@liggitt
Copy link
Member

liggitt commented Dec 6, 2017 •
edited

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Dec 6, 2017
@liggitt
Copy link
Member

liggitt commented Dec 6, 2017

/status in-progress

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@crimsonfaith91 @janetkuo @liggitt

Action required: This pull request requires label changes.

priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.

Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 953082b into kubernetes:master Dec 6, 2017
@crimsonfaith91 crimsonfaith91 deleted the deprecate-v1beta2 branch December 6, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

Assignees

@liggitt liggitt

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

No deprecation message for apps/v1beta2 core controllers and controller revision
9 participants
@crimsonfaith91 @k8s-ci-robot @janetkuo @liggitt @k8s-github-robot @mikedanese @kevin-wangzefeng @deads2k @piosz