Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No deprecation message for apps/v1beta2 core controllers and controller revision #56868

Closed
crimsonfaith91 opened this issue Dec 5, 2017 · 1 comment · Fixed by #56867
Closed

No deprecation message for apps/v1beta2 core controllers and controller revision #56868

crimsonfaith91 opened this issue Dec 5, 2017 · 1 comment · Fixed by #56867
Assignees
@crimsonfaith91
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@crimsonfaith91
Copy link
Contributor

crimsonfaith91 commented Dec 5, 2017 •
edited
Loading

What happened:
There is no deprecation message for apps/v1beta2 core controllers and controller revision in types.go.

What you expected to happen:
There should be a deprecation message for each of the controllers and controller revision as they will be GA in v1.9 release.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 5, 2017
@crimsonfaith91 crimsonfaith91 mentioned this issue Dec 5, 2017
Merged
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 6, 2017
@dims
Copy link
Member

dims commented Dec 6, 2017

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Dec 6, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 6, 2017
vdemeester pushed a commit to vdemeester/kubernetes that referenced this issue Dec 6, 2017
Merge pull request kubernetes#56867 from crimsonfaith91/deprecate-v1b…
953082b 
…eta2

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

add deprecation comments to apps/v1beta2 types.go

**What this PR does / why we need it**:
This PR adds deprecation comments for `apps/v1beta2` statefulset, deployment, replicaset, daemonset, and controller revision in `types.go`.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes#56868

**Release note**:

```release-note
Deprecates apps/v1beta2 StatefulSet, Deployment, ReplicaSet, DaemonSet, and ControllerRevision.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crimsonfaith91 crimsonfaith91

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add deprecation comments to apps/v1beta2 types.go crimsonfaith91/kubernetes
4 participants
@dims @k8s-github-robot @crimsonfaith91 @k8s-ci-robot