Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #55927 #57019

Merged
merged 2 commits into from
Dec 28, 2017
Merged

Automated cherry pick of #55927 #57019

merged 2 commits into from
Dec 28, 2017

Conversation

andyzhangx
Copy link
Member

Cherry pick of #55927 on release-1.7.

#55927: move InitStorageAccount into azure disk provision func

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2017
@andyzhangx
Copy link
Member Author

/assign @rootfs
/sig azure

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 11, 2017
@rootfs
Copy link
Contributor

rootfs commented Dec 11, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2017
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-kubemark-e2e-gce

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce

@jdumars
Copy link
Member

jdumars commented Dec 26, 2017

@wojtek-t could you approve this?

@jdumars
Copy link
Member

jdumars commented Dec 26, 2017

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jdumars, rootfs

Associated issue: #55927

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2017
@jdumars
Copy link
Member

jdumars commented Dec 26, 2017

/test pull-kubernetes-e2e-gce

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 28, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Dec 28, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 3bda299 into kubernetes:release-1.7 Dec 28, 2017
@andyzhangx andyzhangx deleted the automated-cherry-pick-of-#55927-upstream-release-1.7 branch May 8, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andyzhangx @rootfs @jdumars @k8s-ci-robot @k8s-github-robot @wojtek-t