Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Flexvolume as GA #57075

Merged
merged 1 commit into from Dec 12, 2017
Merged

Mark Flexvolume as GA #57075

merged 1 commit into from Dec 12, 2017

Conversation

chakri-nelluri
Copy link
Contributor

Flex volume became GA from release 1.8 onwards. This PR fixes the comments to reflect it.

Fixes #56920

Special notes for your reviewer:

Release note:

Flexvolume feature has graduated to GA.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2017
@chakri-nelluri
Copy link
Contributor Author

@msau42 @verult @saad-ali PTAL

@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 12, 2017
@liggitt
Copy link
Member

liggitt commented Dec 12, 2017

same change needed in vendor/k8s.io/api/core/v1/types.go? also, files generated from docs need regenerating

@liggitt
Copy link
Member

liggitt commented Dec 12, 2017

cc @kubernetes/sig-storage-api-reviews

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 12, 2017
@piosz piosz assigned verult, saad-ali and msau42 and unassigned piosz Dec 12, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2017
@chakri-nelluri
Copy link
Contributor Author

chakri-nelluri commented Dec 12, 2017 •
edited

Thanks @liggitt. Updated vendor api types too.
I tried make generated_files and it did not generate any git diff. Please let me know the procedure to update the generated docs.

@liggitt
Copy link
Member

liggitt commented Dec 12, 2017

run hack/update-all.sh

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2017
@chakri-nelluri
Copy link
Contributor Author

Thanks @liggitt. Submitted the updated files.

@liggitt
Copy link
Member

liggitt commented Dec 12, 2017

/approve
/assign @saad-ali @childsb
@kubernetes/sig-storage-api-reviews has lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2017
@saad-ali
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2017
@verult
Copy link
Contributor

verult commented Dec 12, 2017

/lgtm

@saad-ali saad-ali added this to the v1.9 milestone Dec 12, 2017
@saad-ali saad-ali added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. status/approved-for-milestone labels Dec 12, 2017
@saad-ali saad-ali added status/in-progress do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 12, 2017
@saad-ali
Copy link
Member

Per #56920 (comment) adding this to 1.9 milestone. With do-not-merge label. Release team if you are ok with this, please remove do-not-merge

@saad-ali saad-ali added the kind/bug Categorizes issue or PR as related to a bug. label Dec 12, 2017
@chakri-nelluri
Copy link
Contributor Author

/kind bug

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@chakri-nelluri @childsb @liggitt @msau42 @saad-ali @verult

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@chakri-nelluri
Copy link
Contributor Author

chakri-nelluri commented Dec 12, 2017 •
edited

rebased. @saad-ali I need one more approval from you. :)

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2017
@saad-ali
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chakri-nelluri, liggitt, saad-ali, verult

Associated issue: #56920

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Dec 12, 2017

@saad-ali there's a hold label too! please remove that

@enisoc
Copy link
Member

enisoc commented Dec 12, 2017

LGTM.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d052476 into kubernetes:master Dec 12, 2017
@sttts sttts mentioned this pull request Dec 18, 2017
Closed
@kokhang kokhang mentioned this pull request Jan 11, 2018
Closed
@chakri-nelluri
Copy link
Contributor Author

@saad-ali Please add the cherrypick-candidate for this PR for 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@childsb childsb

@liggitt liggitt

@verult verult

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Remove alpha from Flex Volume docs