Fix TestCadvisorListPodStats failure under mac/darwin #57637
Conversation
GetPodCgroupNameSuffix is not really implemented under darwin (or windows for that matter). So let's just skip over the check for CPU and Memory if that is not set.
k8s-ci-robot
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
@dchen1107 @vishh Could we get a quick look at this one please? :) |
|
/test pull-kubernetes-unit |
|
/test pull-kubernetes-node-e2e |
|
/assign @derekwaynecarr @Random-Liu @dchen1107 @derekwaynecarr @tallclair @vishh @yujuhong PTAL, easy one! |
|
/test all Tests are more than 96 hours old. Re-running tests. |
1 similar comment
|
/test all Tests are more than 96 hours old. Re-running tests. |
|
/retest |
|
/test all Tests are more than 96 hours old. Re-running tests. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, dims, dixudx, geojaz Associated issue: #57636 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
/test all Tests are more than 96 hours old. Re-running tests. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
Automatic merge from submit-queue (batch tested with PRs 62192, 61866, 62206, 62360). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make the test TestCRIListPodStats pass for Darwin and Windows GetPodCgroupNameSuffix is only implemented for Linux, which mean that CPU and Memory stats are only available on Linux. My fix to make the test pass on other OS:es than Linux is to just check CPU and Memory stats on Linux. (This is similar to #57637 which fixed the same problem for the test TestCadvisorListPodStats.) **What this PR does / why we need it**: To make all unit tests pass on macOS/Darwin **Which issue(s) this PR fixes**: Fixes #62177 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
What this PR does / why we need it:
GetPodCgroupNameSuffix is not really implemented under darwin
(or windows for that matter). So let's just skip over the check
for CPU and Memory if that is not set.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #57636
Special notes for your reviewer:
Release note: