YAMLToJSONDecoder drops data after io.ErrShortBuffer #59055
Labels
kind/bug
Categorizes issue or PR as related to a bug.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
Comments
k8s-ci-robot
added
needs-sig
|
/sig api-machinery |
k8s-ci-robot
added
sig/api-machinery
k8s-github-robot
pushed a commit
that referenced
this issue
Jan 31, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add test/fix for ErrShortBuffer edgecase **What this PR does / why we need it**: Found a bug with YAMLToJSONDecoder where subsequent reads after `io.ErrShortBuffer` would return values from the next yaml section, rather than the rest of the section I was reading. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59055 #59055 **Special notes for your reviewer**: **Release note**: ```release-note YAMLDecoder Read now tracks rest of buffer on io.ErrShortBuffer ```
k8s-publishing-bot
added a commit
to kubernetes/apimachinery
that referenced
this issue
Jan 31, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add test/fix for ErrShortBuffer edgecase **What this PR does / why we need it**: Found a bug with YAMLToJSONDecoder where subsequent reads after `io.ErrShortBuffer` would return values from the next yaml section, rather than the rest of the section I was reading. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59055 kubernetes/kubernetes#59055 **Special notes for your reviewer**: **Release note**: ```release-note YAMLDecoder Read now tracks rest of buffer on io.ErrShortBuffer ``` Kubernetes-commit: f3942e7dedc0781aaee0a8dec1e134748b705ae2
tamalsaha
pushed a commit
to gomodules/encoding
that referenced
this issue
Aug 10, 2021
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add test/fix for ErrShortBuffer edgecase **What this PR does / why we need it**: Found a bug with YAMLToJSONDecoder where subsequent reads after `io.ErrShortBuffer` would return values from the next yaml section, rather than the rest of the section I was reading. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59055 kubernetes/kubernetes#59055 **Special notes for your reviewer**: **Release note**: ```release-note YAMLDecoder Read now tracks rest of buffer on io.ErrShortBuffer ``` Kubernetes-commit: f3942e7dedc0781aaee0a8dec1e134748b705ae2
akhilerm
pushed a commit
to akhilerm/apimachinery
that referenced
this issue
Sep 20, 2022
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add test/fix for ErrShortBuffer edgecase **What this PR does / why we need it**: Found a bug with YAMLToJSONDecoder where subsequent reads after `io.ErrShortBuffer` would return values from the next yaml section, rather than the rest of the section I was reading. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #59055 kubernetes/kubernetes#59055 **Special notes for your reviewer**: **Release note**: ```release-note YAMLDecoder Read now tracks rest of buffer on io.ErrShortBuffer ``` Kubernetes-commit: f3942e7dedc0781aaee0a8dec1e134748b705ae2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/kind bug
What happened:
Using
YAMLToJSONDecodersubsequent reads afterio.ErrShortBufferwould return values from the next yaml section, rather than the rest of the section being read.What you expected to happen:
I'd expect the rest of the current section to get returned until the whole section has been read
How to reproduce it (as minimally and precisely as possible):
See tests here: https://github.com/kubernetes/kubernetes/pull/58817/files#diff-3b3ea800b8ebe625d0defd76c2e6f827R57
Anything else we need to know?:
PR to fix: #58817
The text was updated successfully, but these errors were encountered: