New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The `Recycle` persistentVolumeReclaimPolicy should have deprecation notice. #59060

Closed
saad-ali opened this Issue Jan 30, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@saad-ali
Member

saad-ali commented Jan 30, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
The persistentVolumeReclaimPolicy called Recycle is being deprecated. See announcement here. The documentation (comments) in the API (https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/types.go#L478) should mention this.

What you expected to happen:
API documentation should indicate Recycle policy is being deprecated.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

@k8s-ci-robot k8s-ci-robot removed the needs-sig label Jan 30, 2018

ayushpateria added a commit to ayushpateria/kubernetes that referenced this issue Jan 30, 2018

k8s-merge-robot added a commit that referenced this issue Feb 6, 2018

Merge pull request #59063 from ayushpateria/patch-1
Automatic merge from submit-queue (batch tested with PRs 58317, 58687, 57872, 59063, 59328). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add deprecation comment to PersistentVolumeReclaimRecycle

**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #59060

**Special notes for your reviewer**:

**Release note**:

```release-note
Announcing the deprecation of the recycling reclaim policy.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment