Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Priority admission controller should choose one default priority class deterministically #59987

Closed
bsalamat opened this issue Feb 16, 2018 · 0 comments · Fixed by #59991
Closed

Priority admission controller should choose one default priority class deterministically #59987

bsalamat opened this issue Feb 16, 2018 · 0 comments · Fixed by #59991
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@bsalamat
Copy link
Member

bsalamat commented Feb 16, 2018 •
edited

Priority admission controller has the logic to check that only one PriorityClass is marked as global default. However, due to inherent race condition associated with creating multiple API objects at the same time, especially in HA cases, more than one PriorityClass marked as global default may get into the system. In that case, the admission controller must pick deterministically. For example, it could pick the one with lowest priority value.

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

/sig scheduling

ref/ #59679 #59712
cc/ @liggitt
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 16, 2018
@bsalamat bsalamat mentioned this issue Feb 16, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue Feb 21, 2018
Merge pull request #59991 from bsalamat/default_pc
2a604f6 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Pick the PriorityClass with the lowest value of priority in case more than one global default exists

**What this PR does / why we need it**:
Please see the referenced issue.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #59987

**Special notes for your reviewer**:

**Release note**:

```release-note
Priority admission controller picks a global default with the lowest priority value if more than one such default PriorityClass exists.
```

/sig scheduling
cc/ @liggitt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
No milestone
2 participants
@bsalamat @k8s-ci-robot