Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #60183 #60271

Merged
merged 1 commit into from Mar 1, 2018
Merged

Automated cherry pick of #60183 #60271

merged 1 commit into from Mar 1, 2018

Conversation

andyzhangx
Copy link
Member

Cherry pick of #60183 on release-1.7.

#60183: add lock before detaching azure disk

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 23, 2018
@feiskyer
Copy link
Member

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djsly
Copy link
Contributor

djsly commented Feb 23, 2018

/retest

@djsly
Copy link
Contributor

djsly commented Feb 26, 2018

@jdumars what is missing for the cherry-pick to be picked up ? I'm still not familiar enough with the cherry-pick process.

Looks like is it missing a cherrypick-approved label, but from who ? :)

@feiskyer
Copy link
Member

/assign @wojtek-t

@wojtek-t could you help to approve this cherry pick?

@djsly
Copy link
Contributor

djsly commented Feb 27, 2018

/retest

@jdumars
Copy link
Member

jdumars commented Feb 27, 2018

Yes, it should be @wojtek-t approving this

@cblecker cblecker added this to the v1.7 milestone Feb 28, 2018
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. status/approved-for-milestone and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 1, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@djsly
Copy link
Contributor

djsly commented Mar 1, 2018

thanks @wojtek-t , just wondering what is the expected ETA for the next 1.7 minor release ?

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 0414aa3 into kubernetes:release-1.7 Mar 1, 2018
@andyzhangx andyzhangx deleted the automated-cherry-pick-of-#60183-upstream-release-1.7 branch May 8, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@feiskyer feiskyer

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@andyzhangx @feiskyer @k8s-ci-robot @djsly @jdumars @k8s-github-robot @cblecker @wojtek-t