Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #54687: fix CreateVolume: search mode for Dedicated kind #60282

Conversation

andyzhangx
Copy link
Member

Cherry pick of #54687 on release-1.7.

#54687: fix CreateVolume: search mode for Dedicated kind

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 23, 2018
@andyzhangx
Copy link
Member Author

/assign @brendandburns

@andyzhangx
Copy link
Member Author

@brendandburns
I got a customer case that one azure storage account was mistakenly removed by k8s v1.7.7 azure provider, this PR has the fix:

-	// if forced (as in one disk = one storage account)
 -	// delete the account completely
 -	if wasForced {
 -		return c.deleteStorageAccount(storageAccountName)
 -	}

With this PR, there would be no deleteStorageAccount operation in azure cloud provider since it's very dangerous, there is some corner case would lead to this DATA LOSS issue.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@andyzhangx
Copy link
Member Author

/assign @feiskyer

@andyzhangx
Copy link
Member Author

/sig azure
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/azure kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 28, 2018
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@feiskyer
Copy link
Member

/assign @saad-ali for original PR approval

@k8s-ci-robot
Copy link
Contributor

@feiskyer: GitHub didn't allow me to assign the following users: for, original, PR, approval.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @saad-ali for original PR approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-bazel-test
/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-integration

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 1, 2018
@wojtek-t wojtek-t added this to the v1.7 milestone Mar 1, 2018
@wojtek-t wojtek-t added release-note Denotes a PR that will be considered when it comes time to generate release notes. status/approved-for-milestone labels Mar 1, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Mar 2, 2018

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2018
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-bazel-build

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 2, 2018

@andyzhangx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 74b89a36d1803efab1314a2f00fcf7a84d971ac9 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx force-pushed the automated-cherry-pick-of-#54687-upstream-release-1.7 branch from 74b89a3 to 5158418 Compare March 2, 2018 08:33
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Mar 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 8495e84 into kubernetes:release-1.7 Mar 2, 2018
@andyzhangx andyzhangx deleted the automated-cherry-pick-of-#54687-upstream-release-1.7 branch April 13, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants