Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet: fix bug where character device is not recognized #60440

Merged
merged 1 commit into from
Feb 27, 2018
Merged

kubelet: fix bug where character device is not recognized #60440

merged 1 commit into from
Feb 27, 2018

Conversation

andrewsykim
Copy link
Member

@andrewsykim andrewsykim commented Feb 26, 2018 •
edited

What this PR does / why we need it:
Fixes a bug where character devices are not recognized by the kubelet because we return FileTypeBlockDev instead of FileTypeCharDev.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related issue: #5607

Special notes for your reviewer:
Kubelet event for bug: #5607 (comment)

Warning		FailedMount		MountVolume.SetUp failed for volume "dev-fuse" : hostPath type check failed: /dev/fuse is not a character device

Commit where bug was introduced: 57ead48
Release note:

Fixes a bug where character devices are not recongized by the kubelet

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2018
@andrewsykim andrewsykim changed the title fix bug where character devices are not recognized kubelet: fix bug where character device is not recognized Feb 26, 2018
@andrewsykim andrewsykim mentioned this pull request Feb 26, 2018
Closed
@andrewsykim
Copy link
Member Author

cc @dixudx

@saad-ali
Copy link
Member

/lgtm
/approve

This should be cherry picked to affected branches.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2018
@saad-ali saad-ali added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 26, 2018
@saad-ali saad-ali added this to the v1.10 milestone Feb 26, 2018
@saad-ali
Copy link
Member

/test pull-kubernetes-unit
/test pull-kubernetes-verify

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@andrewsykim
Copy link
Member Author

andrewsykim commented Feb 26, 2018 •
edited

Had to rebase to get a test fixed in master

/test pull-kubernetes-verify

@andrewsykim andrewsykim force-pushed the andrewsykim/fix-char-device-mount-bug branch from d918998 to d856a97 Compare February 26, 2018 22:21
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, jsafrane, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Member

/retest

@dixudx
Copy link
Member

dixudx commented Feb 27, 2018

My fault. Thanks @andrewsykim for fixing this.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 60433, 59982, 59128, 60243, 60440). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit e99ec24 into kubernetes:master Feb 27, 2018
@andrewsykim
Copy link
Member Author

Will cherry-pick this into v1.9 today

@andrewsykim andrewsykim mentioned this pull request Feb 27, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Mar 23, 2018
Merge pull request #60510 from andrewsykim/automated-cherry-pick-of-#…
7f0dd79 
…60440-origin-release-1.9

Automatic merge from submit-queue.

Cherry pick 60440 to release v1.9

Cherry pick of #60440

```release-note
kubelet: fix bug where character devices are not recognized
```

cc @saad-ali @jsafrane @dixudx
@bhack bhack mentioned this pull request May 10, 2018
Closed
@tossmilestone tossmilestone mentioned this pull request Jun 26, 2018
Merged
@andrewsykim andrewsykim mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jsafrane jsafrane

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@andrewsykim @saad-ali @k8s-cherrypick-bot @jsafrane @k8s-ci-robot @dixudx @k8s-github-robot