-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old featureGate flag in Readme #60501
Remove old featureGate flag in Readme #60501
Conversation
to specify the ipvs mode before deploying the cluster if want to run kube-proxy in ipvs mode. | ||
|
||
If you are using kubeadm with a configuration file, you can specify the ipvs mode adding `SupportIPVSProxyMode: true` below the `featureGates` field. | ||
If you are using kubeadm with a [configuration file](https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-init/#config-file), you can specify the ipvs mode adding `SupportIPVSProxyMode: true` below the `kubeProxy` field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/ok-to-test |
friendly ping @m1093782566 |
/assign We should also enable IPVS in feature gates by default so that making it work, xref: #60540 |
Is this means we don't have to add |
/lgtm |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johscheuer, m1093782566 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not really... We should keep the feature gates until IPVS goes to GA, |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
Automatic merge from submit-queue (batch tested with PRs 58171, 58036, 60540). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Enable IPVS feature gateway by default since it's already beta **What this PR does / why we need it**: Per #60501, kubeadm init doesn't support the --feature-gates=SupportIPVSProxyMode=true flag anymore since IPVS is in beta and not alpha anymore. We should enable IPVS feature gateway by default to make kubeadm set up IPVS proxy properly. **Which issue(s) this PR fixes**: Fixes #60543 **Special notes for your reviewer**: **Release note**: ```release-note Enable IPVS feature gateway by default ```
What this PR does / why we need it:
This PR corrects the Readme for ipvs mode: https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/ipvs/README.md.
kubeadm init
doesn't support the--feature-gates=SupportIPVSProxyMode=true
flag anymore since IPVS is in beta and not alpha anymore.Special notes for your reviewer:
Used kubeadm version:
Release note: