Set node external IP for azure node when disabling UseInstanceMetadata

[feiskyer]

What this PR does / why we need it:

This PR sets node external IP for azure node disabling UseInstanceMetadata.

It also adds a check of whether it is running locally when UseInstanceMetadata.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #60958

Special notes for your reviewer:

Release note:

Set node external IP for azure node when disabling UseInstanceMetadata

[feiskyer]

/sig azure

[feiskyer]

/kind bug

[andyzhangx]

@feiskyer if it's a bug, is there a bug description?

[feiskyer]

@andyzhangx Yep, forgot to include it. It fixes #60958.

[khenidak]

While the code is good to go (specially in case of current node). I am not sure if we should assign public/external IPs to nodes. Do we assign public IPs to nodes?

[feiskyer]

While the code is good to go (specially in case of current node). I am not sure if we should assign public/external IPs to nodes. Do we assign public IPs to nodes?

acs-engine or aks won't do this. It determines to users. If users assigned a public IP, then it should be included in node's addresses (we have already done this with UseInstanceMetadata=true).

[khenidak]

That is correct.
/LGTM

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, khenidak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cloudprovider/providers/azure/OWNERS [feiskyer,khenidak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

Added to v1.10 milestone since it is a bug fix. cc @jdumars

[feiskyer]

/status approved-for-milestone

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@feiskyer @khenidak

Pull Request Labels

• sig/azure: Pull Request will be escalated to these SIGs if needed.
• priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
• kind/bug: Fixes a bug discovered during the current release.

Help

• Additional instructions
• Commands for setting labels

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

[jdumars]

FYI @mbohlool @jpbetz this is a high priority cherry pick going to 1.9.x and 1.8.x

[k8s-cherrypick-bot]

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.