Clean up fake mounters #61502
Labels
kind/bug
Categorizes issue or PR as related to a bug.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
sig/storage
Categorizes an issue or PR as relevant to SIG Storage.
Comments
k8s-ci-robot
added
sig/storage
|
Is this a beginner friendly issue? If so I will be happy to work on this |
|
Yes totally! |
|
@msau42 I don't find any other |
|
Sorry I wasn't being specific. If you look at #61489, you can see all the places we need to change whenever we add a new function to the Mounter interface. Many of these are fake implementations for unit tests, so there may be some opportunity for consolidation there. |
k8s-github-robot
pushed a commit
that referenced
this issue
Jun 20, 2018
Automatic merge from submit-queue (batch tested with PRs 64142, 64426, 62910, 63942, 64548). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Clean up fake mounters. **What this PR does / why we need it**: Fixes #61502 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: list of fake mounters: - (keep) pkg/util/mount.FakeMounter - (removed) pkg/kubelet/cm.fakeMountInterface: - (inherit from mount.FakeMounter) pkg/util/mount.fakeMounter - (inherit from mount.FakeMounter) pkg/util/removeall.fakeMounter - (removed) pkg/volume/host_path.fakeFileTypeChecker **Release note**: ```release-note NONE ```
codenrhoden
pushed a commit
to codenrhoden/utils
that referenced
this issue
Jul 12, 2019
Automatic merge from submit-queue (batch tested with PRs 64142, 64426, 62910, 63942, 64548). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Clean up fake mounters. **What this PR does / why we need it**: Fixes kubernetes/kubernetes#61502 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: list of fake mounters: - (keep) pkg/util/mount.FakeMounter - (removed) pkg/kubelet/cm.fakeMountInterface: - (inherit from mount.FakeMounter) pkg/util/mount.fakeMounter - (inherit from mount.FakeMounter) pkg/util/removeall.fakeMounter - (removed) pkg/volume/host_path.fakeFileTypeChecker **Release note**: ```release-note NONE ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a BUG REPORT or FEATURE REQUEST?:
@kubernetes/sig-storage-bugs
/kind cleanup
What happened:
There are too many FakeMounter implementations in the codebase. It's annoying to have to update all of them whenever we have to change the Mounter interface. They should all be consolidated to use the FakeMounter implementation in pkg/util/mount/fake.go.
The text was updated successfully, but these errors were encountered: