Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.10] Automated cherry pick of #61373: Use inner volume name instead of outer volume name for subpath directory #61518

Merged
merged 1 commit into from Mar 23, 2018
Merged

[1.10] Automated cherry pick of #61373: Use inner volume name instead of outer volume name for subpath directory #61518

merged 1 commit into from Mar 23, 2018

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Mar 22, 2018 •
edited

Cherry pick of #61373 on release-1.10.

#61373: Use inner volume name instead of outer volume name for subpath directory

Release note:

ACTION REQUIRED: In-place node upgrades to this release from versions 1.7.14, 1.8.9, and 1.9.4 are not supported if using subpath volumes with PVCs.  Such pods should be drained from the node first.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 22, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 22, 2018
@msau42
Copy link
Member Author

msau42 commented Mar 22, 2018

/assign @saad-ali @tallclair

@liggitt liggitt changed the title Automated cherry pick of #61373: Use inner volume name instead of outer volume name for subpath directory [1.10] Automated cherry pick of #61373: Use inner volume name instead of outer volume name for subpath directory Mar 22, 2018
@jingxu97 jingxu97 mentioned this pull request Mar 22, 2018
Closed
5 tasks
@liggitt
Copy link
Member

liggitt commented Mar 22, 2018

/kind bug
/priority critical-urgent
/status approved-for-milestone
/sig storage
/milestone v1.10
/assign @calebamiles

@k8s-ci-robot k8s-ci-robot added status/approved-for-milestone kind/bug Categorizes issue or PR as related to a bug. labels Mar 22, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Mar 22, 2018
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 22, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@calebamiles @msau42 @saad-ali @tallclair

Pull Request Labels
  • sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@calebamiles calebamiles added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 22, 2018
@calebamiles
Copy link
Contributor

@saad-ali, @tallclair please take a look

cc: @jdumars, @kubernetes/kubernetes-release-managers

@saad-ali
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2018
@saad-ali
Copy link
Member

/assign @tallclair

@jdumars
Copy link
Member

jdumars commented Mar 23, 2018

@Random-Liu @derekwaynecarr @tallclair @vishh @yujuhong PTAL for approval ASAP, so this can make 1.10 on Monday

@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, saad-ali, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Mar 23, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit fc32d2f into kubernetes:release-1.10 Mar 23, 2018
@msau42 msau42 mentioned this pull request Mar 26, 2018
Merged
@msau42 msau42 deleted the automated-cherry-pick-of-#61373-upstream-release-1.10 branch November 17, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@mtaufen mtaufen Awaiting requested review from mtaufen

@screeley44 screeley44 Awaiting requested review from screeley44

@verult verult Awaiting requested review from verult

Assignees

@calebamiles calebamiles

@saad-ali saad-ali

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@msau42 @liggitt @k8s-github-robot @calebamiles @saad-ali @jdumars @tallclair @k8s-ci-robot