Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add initial translation for pt_BR for kubectl #61595

Merged
merged 1 commit into from
Dec 11, 2020
Merged

add initial translation for pt_BR for kubectl #61595

merged 1 commit into from
Dec 11, 2020
+6,091 −0

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 23, 2018 •
edited by liggitt
Loading

What this PR does / why we need it:
This PR provides first attempt to translate kubectl in Brazilian Portuguese (related to #40645, #45573,
#45562, #40591, #46559, #51867).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
N/A

Special notes for your reviewer:
This PR requires Brazilian people to assist in the review. I'm native in Brazilian Portuguese.

Release note:

NONE

Please let me know if this is good, then I will finisht the other strings, otherwise I will drop this PR

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 23, 2018
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 23, 2018
@cpanato cpanato changed the title [WIP] add initial translation for pt_BR [WIP] add initial translation for pt_BR for kubectl Mar 23, 2018
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2018
@cpanato cpanato force-pushed the pt_BR branch 2 times, most recently from 6b992cf to a81a86f Compare June 4, 2018 12:39
@mengqiy
Copy link
Member

mengqiy commented Jun 6, 2018

@cpanato Can you find some folks who speak Brazilian Portuguese in the community to review this PR?

@cpanato
Copy link
Member Author

cpanato commented Jun 8, 2018

@mengqiy sorry for the delay to answer. Sure I can find some folks :)

@ismaelvacco
Copy link

ismaelvacco commented Jun 10, 2018 •
edited
Loading

Can you help to review this PR? I’m native speaker Brazilian Portuguese.

mauri870
mauri870 suggested changes Jun 26, 2018
View reviewed changes
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Outdated Show resolved Hide resolved
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Outdated Show resolved Hide resolved
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Outdated Show resolved Hide resolved
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Outdated Show resolved Hide resolved
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Outdated Show resolved Hide resolved
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Outdated Show resolved Hide resolved
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Outdated Show resolved Hide resolved
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Outdated Show resolved Hide resolved
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Outdated Show resolved Hide resolved
translations/kubectl/pt_BR/LC_MESSAGES/k8s.po Show resolved Hide resolved
@mauri870
Copy link
Member

mauri870 commented Jun 27, 2018 •
edited
Loading

@cpanato Can I help you with the translation and/or review of the remaining parts?

@cpanato
Copy link
Member Author

cpanato commented Jun 27, 2018

@mauri870 thanks for the review! I'm almost done, and I will update based on your feedback!

@mauri870
Copy link
Member

@cpanato I'm glad you're going to finish this soon 😄. When it's done please ping me so I can review it again.

@cpanato
Copy link
Member Author

cpanato commented Jun 27, 2018

@ismaelvacco but you are welcome to push commits to my branch 😄

@marceloboeira
Copy link

@cpanato any updates here? interested in contributing 💃

@cpanato
Copy link
Member Author

cpanato commented Sep 3, 2018

@marceloboeira please start looking at the existing ones and also you can push to my branch new strings 😄

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Sep 27, 2018
@rikatz
Copy link
Contributor

rikatz commented Nov 23, 2020

@cpanato finished the first pass of review :D

soltysh
soltysh approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, marceloboeira, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@sttts
Copy link
Contributor

sttts commented Nov 24, 2020

/retest

@pwittrock
Copy link
Member

@cpanato are you still active and interested in seeing this PR merged? (2 years is a long time to wait)

@cpanato
Copy link
Member Author

cpanato commented Dec 9, 2020

@pwittrock yes and so sorry for that, I'm working to update the PR based on the review feedback, i think this will be ready by tomorrow or friday

@cpanato
Copy link
Member Author

cpanato commented Dec 11, 2020

thanks for the long review @rikatz and for our discussion over slack. all done

some items we need to review the main strings (English) and make fixes there first then propagate to the other translations.

@cpanato
Copy link
Member Author

cpanato commented Dec 11, 2020

/test ls

@k8s-ci-robot
Copy link
Contributor

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-kubernetes-bazel-build
  • /test pull-kubernetes-bazel-test
  • /test pull-kubernetes-conformance-image-test
  • /test pull-kubernetes-conformance-kind-ipv6-parallel
  • /test pull-kubernetes-dependencies
  • /test pull-kubernetes-dependencies-canary
  • /test pull-kubernetes-e2e-ipvs-azure-dualstack
  • /test pull-kubernetes-e2e-iptables-azure-dualstack
  • /test pull-kubernetes-e2e-aws-eks-1-13-correctness
  • /test pull-kubernetes-files-remake
  • /test pull-kubernetes-e2e-gce
  • /test pull-kubernetes-e2e-gce-no-stage
  • /test pull-kubernetes-e2e-gce-kubetest2
  • /test pull-kubernetes-e2e-gce-canary
  • /test pull-kubernetes-e2e-gce-ubuntu
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd-canary
  • /test pull-kubernetes-e2e-gce-rbe
  • /test pull-kubernetes-e2e-gce-alpha-features
  • /test pull-kubernetes-e2e-gce-device-plugin-gpu
  • /test pull-kubernetes-integration
  • /test pull-kubernetes-cross
  • /test pull-kubernetes-e2e-kind
  • /test pull-kubernetes-e2e-kind-canary
  • /test pull-kubernetes-e2e-kind-ipv6
  • /test pull-kubernetes-e2e-kind-ipv6-canary
  • /test pull-kubernetes-conformance-kind-ga-only
  • /test pull-kubernetes-conformance-kind-ga-only-parallel
  • /test pull-kubernetes-e2e-kops-aws
  • /test pull-kubernetes-bazel-build-canary
  • /test pull-kubernetes-bazel-test-canary
  • /test pull-kubernetes-bazel-test-integration-canary
  • /test pull-kubernetes-local-e2e
  • /test pull-publishing-bot-validate
  • /test pull-kubernetes-e2e-gce-network-proxy-http-connect
  • /test pull-kubernetes-e2e-gce-network-proxy-grpc
  • /test pull-kubernetes-e2e-gci-gce-autoscaling
  • /test pull-kubernetes-e2e-aks-engine-azure
  • /test pull-kubernetes-e2e-azure-disk
  • /test pull-kubernetes-e2e-azure-disk-vmss
  • /test pull-kubernetes-e2e-azure-file
  • /test pull-kubernetes-e2e-kind-dual-canary
  • /test pull-kubernetes-e2e-kind-ipvs-dual-canary
  • /test pull-kubernetes-e2e-gci-gce-ipvs
  • /test pull-kubernetes-node-e2e
  • /test pull-kubernetes-node-e2e-podutil
  • /test pull-kubernetes-e2e-containerd-gce
  • /test pull-kubernetes-node-e2e-containerd
  • /test pull-kubernetes-node-e2e-alpha
  • /test pull-kubernetes-node-kubelet-serial-cpu-manager
  • /test pull-kubernetes-node-kubelet-serial-topology-manager
  • /test pull-kubernetes-node-kubelet-serial-hugepages
  • /test pull-kubernetes-node-crio-cgrpv2-e2e
  • /test pull-kubernetes-node-crio-e2e
  • /test pull-kubernetes-node-kubelet-serial-memory-manager
  • /test pull-kubernetes-e2e-gce-100-performance
  • /test pull-kubernetes-e2e-gce-big-performance
  • /test pull-kubernetes-e2e-gce-correctness
  • /test pull-kubernetes-e2e-gce-large-performance
  • /test pull-kubernetes-kubemark-e2e-gce-big
  • /test pull-kubernetes-kubemark-e2e-gce-scale
  • /test pull-kubernetes-e2e-gce-storage-slow
  • /test pull-kubernetes-e2e-gce-storage-snapshot
  • /test pull-kubernetes-e2e-gce-storage-slow-rbe
  • /test pull-kubernetes-e2e-gce-csi-serial
  • /test pull-kubernetes-e2e-gce-iscsi
  • /test pull-kubernetes-e2e-gce-iscsi-serial
  • /test pull-kubernetes-e2e-gce-storage-disruptive
  • /test pull-kubernetes-e2e-aks-engine-azure-windows
  • /test pull-kubernetes-e2e-aks-engine-windows-contianerd
  • /test pull-kubernetes-e2e-azure-disk-windows
  • /test pull-kubernetes-e2e-azure-file-windows
  • /test pull-kubernetes-e2e-aks-engine-windows-gpu
  • /test pull-kubernetes-typecheck
  • /test pull-kubernetes-verify-govet-levee
  • /test pull-kubernetes-verify
  • /test pull-kubernetes-e2e-windows-gce

Use /test all to run the following jobs:

  • pull-kubernetes-bazel-build
  • pull-kubernetes-bazel-test
  • pull-kubernetes-dependencies
  • pull-kubernetes-e2e-gce-ubuntu-containerd
  • pull-kubernetes-integration
  • pull-kubernetes-e2e-kind
  • pull-kubernetes-e2e-kind-ipv6
  • pull-kubernetes-conformance-kind-ga-only-parallel
  • pull-kubernetes-node-e2e
  • pull-kubernetes-e2e-gce-100-performance
  • pull-kubernetes-typecheck
  • pull-kubernetes-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Dec 11, 2020

/test pull-kubernetes-e2e-kind-ipv6

@cpanato
Copy link
Member Author

cpanato commented Dec 11, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2020
@rikatz
Copy link
Contributor

rikatz commented Dec 11, 2020

/lgtm

There are still some typos and some missing translations, but overall it's good. I would leave the missing parts as some good first issue for someone willing to contribute :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2020
@rikatz
Copy link
Contributor

rikatz commented Dec 11, 2020

@cpanato Thank you for the hard work here!

@k8s-ci-robot k8s-ci-robot merged commit 7c60d8e into kubernetes:master Dec 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 11, 2020
@cpanato cpanato deleted the pt_BR branch December 14, 2020 12:57
@github-actions github-actions bot mentioned this pull request Dec 16, 2020
Open
@rikatz rikatz mentioned this pull request Feb 2, 2021
Closed
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 27, 2021
@mauri870 mauri870 mentioned this pull request Jun 14, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@femrtnz femrtnz femrtnz left review comments

@rikatz rikatz rikatz left review comments

@mauri870 mauri870 mauri870 requested changes

@soltysh soltysh soltysh approved these changes

@marceloboeira marceloboeira marceloboeira approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mengqiy mengqiy Awaiting requested review from mengqiy

@sttts sttts Awaiting requested review from sttts

Assignees

@soltysh soltysh

@rikatz rikatz

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.