-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Removed hardcoded images from yaml files #63600
tests: Removed hardcoded images from yaml files #63600
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/ok-to-test |
f01c729
to
95f125b
Compare
95f125b
to
44c68ab
Compare
/retest |
44c68ab
to
a327b4d
Compare
/assign @kow3ns |
a327b4d
to
5aed336
Compare
/lgtm - fixes some Windows tests |
5a561e8
to
096be34
Compare
/test pull-kubernetes-bazel-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm not sure about turning those doc .yaml files into templates, please see if docs are using them... but if they're ok to template, then I'd prefer if we could use something less brittle if new templates/images are added
@BCLAU - can you update based on the feedback above? |
@PatrickLang you will need /priority and /kind labels for this PR to be able to merge |
8518eba
to
b308ef6
Compare
per discussion in sig-arch, let's move this out to 1.14 /milestone v1.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits, nearly there
b308ef6
to
e2b6f68
Compare
/test pull-kubernetes-godeps |
Some tests use .yaml files to deploy pods, which have hardcoded images. Those images cannot be used for Windows containers. The image names can be injected by the tests themselves, based on the configured registries.
c772595
to
fd4f553
Compare
@BCLAU: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-kubemark-e2e-gce |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bclau, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Some tests use .yaml files to deploy pods, which have hardcoded
images. Those images cannot be used for Windows containers.
The image names can be injected by the tests themselves, based on
the configured registries.
Related to issue #60487
Special notes for your reviewer:
Release note: