-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit Creating CustomResourceDefinitions from apiextensions-apiserver integration tests #63656
Comments
We need a general mechanism for apiservers (in HA) to coordinate on flipping the status to the correct state at the correct time, and not just for CRDs... |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/remove-kind feature |
/kind technical-debt |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently, the logic behind creating CustomResourceDefinitions in
apiextensions-apiserver
integration tests is ugly and could be improved. TheCreateNewCustomResourceDefinition
function creates CRD and then polls to make sure REST and cache storages are fully-initialized (there could be a race between initializing storages, check out this comment).The polling is done by trying to perform each supported operation (list/watch/create/delete), and if there's no error, it's safe to say CRD is created and initialized.
As this is complicated, we want to try to replace it by utilizing
EstablishingController
, which is being implemented in #63068.I would like to give a try on fixing this issue once #63068 is merged.
/kind feature
/sig api-machinery
/area custom-resources
/cc @sttts
The text was updated successfully, but these errors were encountered: