Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #63720: log error for os.NewComputeV2 #63721

Merged
merged 1 commit into from May 30, 2018
Merged

Automated cherry pick of #63720: log error for os.NewComputeV2 #63721

merged 1 commit into from May 30, 2018

Conversation

dims
Copy link
Member

@dims dims commented May 11, 2018

Cherry pick of #63720 on release-1.10.

#63720: log error for os.NewComputeV2

@dims
log error for os.NewComputeV2
e7ddffc 
Since we are returning false, we are kind of losing the error message,
so we should at least log it.
@k8s-ci-robot
Copy link
Contributor

@dims: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #63720.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2018
@k8s-ci-robot
Copy link
Contributor

@dims: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 11, 2018
@dims
Copy link
Member Author

dims commented May 11, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2018
@dims
Copy link
Member Author

dims commented May 11, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2018
@dims
Copy link
Member Author

dims commented May 11, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 11, 2018
@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 14, 2018
@dims
Copy link
Member Author

dims commented May 17, 2018

/assign @dklyle
/assign @hogepodge

@hogepodge
Copy link

/approve

@MaciekPytel
Copy link
Contributor

/hold
Freezing branch for final testing before 1.10.3.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2018
@MaciekPytel
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2018
@MaciekPytel
Copy link
Contributor

@hogepodge @dklyle Can you lgtm?

@dims
Copy link
Member Author

dims commented May 29, 2018

@hogepodge @dklyle can you please lgtm?

@dklyle
Copy link

dklyle commented May 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@FengyunPan2
Copy link
Contributor

/lgtm

@hogepodge
Copy link

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, dklyle, FengyunPan2, hogepodge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MaciekPytel
Copy link
Contributor

Huh, looks like we can't merge cherry-picks without milestone during code slush. Adding milestone and labels.

@MaciekPytel MaciekPytel added this to the v1.10 milestone May 30, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@FengyunPan2 @dims @dklyle @hogepodge

Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.10 milestone.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.
sig owner: Must specify at least one label prefixed with sig/.

Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 8af495e into kubernetes:release-1.10 May 30, 2018
@dims
Copy link
Member Author

dims commented May 30, 2018

Thanks @MaciekPytel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FengyunPan2 FengyunPan2 FengyunPan2 approved these changes

@NickrenREN NickrenREN Awaiting requested review from NickrenREN

Assignees

@hogepodge hogepodge

@dklyle dklyle

@FengyunPan2 FengyunPan2

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dims @k8s-ci-robot @hogepodge @MaciekPytel @dklyle @fejta-bot @FengyunPan2 @k8s-github-robot