-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #63720: log error for os.NewComputeV2 #63721
Automated cherry pick of #63720: log error for os.NewComputeV2 #63721
Conversation
Since we are returning false, we are kind of losing the error message, so we should at least log it.
@dims: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #63720. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dims: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/hold cancel |
/release-note-none |
/assign @dklyle |
/approve |
/hold |
/hold cancel |
@hogepodge @dklyle Can you lgtm? |
@hogepodge @dklyle can you please lgtm? |
/lgtm |
/retest Review the full test history for this PR. Silence the bot with an |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, dklyle, FengyunPan2, hogepodge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Huh, looks like we can't merge cherry-picks without milestone during code slush. Adding milestone and labels. |
[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete @FengyunPan2 @dims @dklyle @hogepodge Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.10 milestone. kind: Must specify exactly one of |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Thanks @MaciekPytel ! |
Cherry pick of #63720 on release-1.10.
#63720: log error for os.NewComputeV2