Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to run Calico 3.0+ with existing addon yaml files under cluster/addons/calico-policy-controller/ #65045

Closed
jingax10 opened this issue Jun 13, 2018 · 1 comment · Fixed by #65022 or #65024
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@jingax10
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:

The K8s cluster with NETWORK_POLICY_PROVIDER=calico could not be brought up in GCE when using Calico 3.0+ release. It would complain a number of issues, e.g., missing CRDs, authentication issues, ...

What you expected to happen:

K8s cluster can be brought up with Calico 3.0+ release

How to reproduce it (as minimally and precisely as possible):

  • Change image versions in cluster/addons/calico-policy-controller/{calico-node-daemonset, typha-depolyment}.yaml to Calico 3.0+ release

  • make quick-release

  • set ENV vars

export KUBE_CLUSTER_INITIALIZATION_TIMEOUT=3600
export NUM_NODES=1
export KUBE_UP_AUTOMATIC_CLEANUP=true
export KUBE_GCE_ZONE=us-west1-a
export KUBE_GCE_ENABLE_IP_ALIASES=true
export NETWORK_POLICY_PROVIDER=calico

  • run cluster/kube-up.sh to spin up a K8s cluster on GCE

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration: gce
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/bug Categorizes issue or PR as related to a bug. labels Jun 13, 2018
@jingax10
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 13, 2018
k8s-github-robot pushed a commit that referenced this issue Jun 21, 2018
Automatic merge from submit-queue (batch tested with PRs 64140, 64898, 65022, 65037, 65027). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update Calico addon yamls to make it work for both 2.x and 3.x. versions.

**What this PR does / why we need it**:

Without this PR, one could not run Calico 3.0+.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65045 

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
k8s-github-robot pushed a commit that referenced this issue Jun 22, 2018
Automatic merge from submit-queue (batch tested with PRs 65024, 65287, 65345, 64693, 64941). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add a helper function to customize K8s addon yamls and use it to customize Calico addons on GKE

**What this PR does / why we need it**:

Allow customizing Calico addon in GCP. With #65022, this allows us to do a couple of things:, e.g., run Calico 3.0+ on GCP, use a non-default MTU etc.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65045, #65067

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
k8s-github-robot pushed a commit that referenced this issue Jul 13, 2018
Automatic merge from submit-queue.

Backport Calico related fixes to release 1.11.

**What this PR does / why we need it**:
We need to run Calico 3.0+ on GCP and we need to customize MTU when Calico CNI is used on GCP.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65045 #65067

**Special notes for your reviewer**:

**Release note**:

```release-note
"NONE"
```
k8s-github-robot pushed a commit that referenced this issue Jul 14, 2018
Automatic merge from submit-queue.

Backport Calico related fixes to release 1.10

**What this PR does / why we need it**:
We need to run Calico 3.0+ on GCP and we need to customize MTU when Calico CNI is used on GCP.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65045 #65067

**Special notes for your reviewer**:

**Release note**:

```release-note
"NONE"
```
k8s-github-robot pushed a commit that referenced this issue Jul 18, 2018
Automatic merge from submit-queue.

Backport Calico related fixes to release 1.9

**What this PR does / why we need it**:
We need to run Calico 3.0+ on GCP and we need to customize MTU when Calico CNI is used on GCP.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65045 #65067

**Special notes for your reviewer**:

**Release note**:

```release-note
"NONE"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
2 participants