Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leader election client should set timeout #65090

Closed
hzxuzhonghu opened this issue Jun 14, 2018 · 3 comments · Fixed by #65094
Closed

leader election client should set timeout #65090

hzxuzhonghu opened this issue Jun 14, 2018 · 3 comments · Fixed by #65094
Assignees
@hzxuzhonghu
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@hzxuzhonghu
Copy link
Member

hzxuzhonghu commented Jun 14, 2018 •
edited

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

kube-cm kube-scheduler does not exit when kube-apiserver suspended

What you expected to happen:

kube-cm kube-scheduler should exit after LeaderElector stops leading

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 14, 2018
@hzxuzhonghu
Copy link
Member Author

/sig api-machinery

/kind bug

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 14, 2018
@hzxuzhonghu
Copy link
Member Author

/assign

@hzxuzhonghu hzxuzhonghu mentioned this issue Jun 14, 2018
Merged
@wenjiaswe
Copy link
Contributor

/cc @cheftako

k8s-github-robot pushed a commit that referenced this issue Jul 3, 2018
Merge pull request #65094 from hzxuzhonghu/le-client-timeout
47020f3 
Automatic merge from submit-queue (batch tested with PRs 65094, 65533, 63522, 65694, 65702). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

set leader election client and renew timeout

**What this PR does / why we need it**:

set leader-election client timeout

set timeout for tryAcquireOrRenew

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65090 #65257

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hzxuzhonghu hzxuzhonghu

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set leader election client and renew timeout hzxuzhonghu/kubernetes
3 participants
@hzxuzhonghu @k8s-ci-robot @wenjiaswe