-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Candidate for Conformance] discussion to promote "[sig-api-machinery] Garbage collector should orphan pods created by rc if deleteOptions.OrphanDependents is nil" e2e test #65427
Comments
@mgdevstack: Reiterating the mentions to trigger a notification: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fedebongio your guidance on this will be helpful. Should we consider rewriting the e2e test and then promote it? |
/cc @caesarxuchao who is on the blamelist for this test |
As discussed offline in an email thread, @mgdevstack can help rewrite the test as long as there's some guidance to help him get started. |
So @mgdevstack as per your observation here there's already a conformance test for deleteOptions? Ref: https://github.com/kubernetes/kubernetes/blob/master/test/conformance/testdata/conformance.txt#L3 @caesarxuchao and @fedebongio let us know if the test referenced above tests the functionality fully or you need it updated. |
Yes @AishSundar, mentioned conformance test is verifying GC behavior with Orphan propagation. |
@mgdevstack based on discussion offline, it sounds like we don't want to bother promoting to conformance because |
Automatic merge from submit-queue (batch tested with PRs 58058, 67033, 66921, 66956). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Added comment to track deleteOptions.OrphanDependents e2e for conformance promotion in future **What this PR does / why we need it**: - Added a comment to track below mentioned e2e tests for conformance promotion in future. - Prevents additional effort to evaluate again for promotion. **E2E -** - Garbage collector should orphan pods created by rc if deleteOptions.OrphanDependents is nil **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #65427 **Special notes for your reviewer**: #65427 (comment) **Release note**: ```release-note NONE ``` /area conformance @kubernetes/sig-architecture-pr-reviews
Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
What happened:
With respect to the discussion to promote e2e tests for conformance, while going through codebase, It is observed that this e2e test case is using deprecated (in 1.7) deleteOptions (OrphanDependents=nil). So we may not promote it to conformance as it is not meeting the conformance guidelines.
What you expected to happen:
Anything else we need to know?:
Any suggestion or feedback is expected in order to promote this e2e test.
Environment:
kubectl version
):uname -a
):cc @fedebongio, @AishSundar
/area conformance
@kubernetes/sig-architecture-feature-requests
The text was updated successfully, but these errors were encountered: