Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Candidate for Conformance] discussion to promote "[sig-api-machinery] Garbage collector should orphan pods created by rc if deleteOptions.OrphanDependents is nil" e2e test #65427

Closed
mgdevstack opened this issue Jun 25, 2018 · 7 comments · Fixed by #66956
Labels
area/conformance Issues or PRs related to kubernetes conformance tests kind/feature Categorizes issue or PR as related to a new feature. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.

Comments

@mgdevstack
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
With respect to the discussion to promote e2e tests for conformance, while going through codebase, It is observed that this e2e test case is using deprecated (in 1.7) deleteOptions (OrphanDependents=nil). So we may not promote it to conformance as it is not meeting the conformance guidelines.

What you expected to happen:

  1. Do not promote this e2e tests for conformance.
  2. Create another e2e test with deleteOptions parameters as propagationPolicy="Orphan" to achieve same behaviour.

Anything else we need to know?:
Any suggestion or feedback is expected in order to promote this e2e test.

Environment:

  • Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.0-alpha.0.1047+3abba251605909-dirty", GitCommit:"3abba25160590921fec61236ba012a8bbd757d6c", GitTreeState:"dirty", BuildDate:"2018-06-18T07:29:01Z", GoVersion:"go1.10.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.0-alpha.0.1047+3abba251605909-dirty", GitCommit:"3abba25160590921fec61236ba012a8bbd757d6c", GitTreeState:"dirty", BuildDate:"2018-06-18T07:29:01Z", GoVersion:"go1.10.2", Compiler:"gc", Platform:"linux/amd64"}
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

cc @fedebongio, @AishSundar
/area conformance
@kubernetes/sig-architecture-feature-requests

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. kind/feature Categorizes issue or PR as related to a new feature. area/conformance Issues or PRs related to kubernetes conformance tests labels Jun 25, 2018
@k8s-ci-robot
Copy link
Contributor

@mgdevstack: Reiterating the mentions to trigger a notification:
@kubernetes/sig-architecture-feature-requests

In response to this:

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
With respect to the discussion to promote e2e tests for conformance, while going through codebase, It is observed that this e2e test case is using deprecated (in 1.7) deleteOptions (OrphanDependents=nil). So we may not promote it to conformance as it is not meeting the conformance guidelines.

What you expected to happen:

  1. Do not promote this e2e tests for conformance.
  2. Create another e2e test with deleteOptions parameters as propagationPolicy="Orphan" to achieve same behaviour.

Anything else we need to know?:
Any suggestion or feedback is expected in order to promote this e2e test.

Environment:

  • Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.0-alpha.0.1047+3abba251605909-dirty", GitCommit:"3abba25160590921fec61236ba012a8bbd757d6c", GitTreeState:"dirty", BuildDate:"2018-06-18T07:29:01Z", GoVersion:"go1.10.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.0-alpha.0.1047+3abba251605909-dirty", GitCommit:"3abba25160590921fec61236ba012a8bbd757d6c", GitTreeState:"dirty", BuildDate:"2018-06-18T07:29:01Z", GoVersion:"go1.10.2", Compiler:"gc", Platform:"linux/amd64"}
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

cc @fedebongio, @AishSundar
/area conformance
@kubernetes/sig-architecture-feature-requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AishSundar
Copy link
Contributor

@fedebongio your guidance on this will be helpful. Should we consider rewriting the e2e test and then promote it?

@selfmanagingresource
Copy link
Contributor

/cc @caesarxuchao who is on the blamelist for this test

@AishSundar
Copy link
Contributor

As discussed offline in an email thread, @mgdevstack can help rewrite the test as long as there's some guidance to help him get started.

@AishSundar
Copy link
Contributor

So @mgdevstack as per your observation here there's already a conformance test for deleteOptions? Ref: https://github.com/kubernetes/kubernetes/blob/master/test/conformance/testdata/conformance.txt#L3

@caesarxuchao and @fedebongio let us know if the test referenced above tests the functionality fully or you need it updated.

@mgdevstack
Copy link
Contributor Author

Yes @AishSundar, mentioned conformance test is verifying GC behavior with Orphan propagation.

@spiffxp
Copy link
Member

spiffxp commented Aug 1, 2018

@mgdevstack based on discussion offline, it sounds like we don't want to bother promoting to conformance because deleteOptions.OrphanDependents is deprecated, let's document this next to the test to close this out, so we don't lose track and try promoting this in the future

k8s-github-robot pushed a commit that referenced this issue Aug 7, 2018
Automatic merge from submit-queue (batch tested with PRs 58058, 67033, 66921, 66956). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Added comment to track deleteOptions.OrphanDependents e2e for conformance promotion in future

**What this PR does / why we need it**:
- Added a comment to track below mentioned e2e tests for conformance promotion in future.
- Prevents additional effort to evaluate again for promotion.

**E2E -**
- Garbage collector should orphan pods created by rc if deleteOptions.OrphanDependents is nil

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65427 

**Special notes for your reviewer**:
#65427 (comment)

**Release note**:

```release-note
NONE
```
/area conformance
@kubernetes/sig-architecture-pr-reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance Issues or PRs related to kubernetes conformance tests kind/feature Categorizes issue or PR as related to a new feature. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
None yet
5 participants