Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #64895: In case storage class parameters are empty, create a new map #65591

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Automated cherry pick of #64895: In case storage class parameters are empty, create a new map #65591

merged 1 commit into from
Jul 3, 2018

Conversation

harsh-px
Copy link
Contributor

Cherry pick of #64895 on release-1.9.

#64895: In case storage class parameters are empty, create a new map

In case storage class parameters are empty, create a new map for Port…
cbb6d0a 
…worx volume labels

Fixes kubernetes#64894

Signed-off-by: Harsh Desai <harsh@portworx.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 28, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 28, 2018
@davidz627
Copy link
Contributor

/lgtm
/assign @jsafrane
/assign @mbohlool

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2018
@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, harsh-px, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2018
@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jun 29, 2018
@harsh-px
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@harsh-px: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harsh-px
Copy link
Contributor Author

harsh-px commented Jul 2, 2018

@mbohlool Can you trigger the retest? The test failures have nothing to do with my change and I'm now allowed to retest.

@davidz627
Copy link
Contributor

/retest

@idealhack
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 2facc7d into kubernetes:release-1.9 Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@msau42 msau42 Awaiting requested review from msau42

Assignees

@mbohlool mbohlool

@jsafrane jsafrane

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@harsh-px @davidz627 @jsafrane @k8s-ci-robot @idealhack @k8s-github-robot @mbohlool