Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In case storage class parameters are empty, create a new map for Portworx volume labels #64895

Merged
merged 1 commit into from
Jun 21, 2018
Merged

In case storage class parameters are empty, create a new map for Portworx volume labels #64895

merged 1 commit into from
Jun 21, 2018

Conversation

harsh-px
Copy link
Contributor

@harsh-px harsh-px commented Jun 7, 2018

Signed-off-by: Harsh Desai harsh@portworx.com

What this PR does / why we need it:

Fixes #64894

Release note:

Fixes an issue where Portworx PVCs remain in pending state when created using a StorageClass with empty parameters

In case storage class parameters are empty, create a new map for Port…
b5234d3 
…worx volume labels

Fixes kubernetes#64894

Signed-off-by: Harsh Desai <harsh@portworx.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2018
@davidz627
Copy link
Contributor

/ok-to-test

Would recommend writing a unit/e2e test to test this functionality

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 7, 2018
@harsh-px
Copy link
Contributor Author

harsh-px commented Jun 8, 2018

/retest

1 similar comment
@harsh-px
Copy link
Contributor Author

harsh-px commented Jun 8, 2018

/retest

@harsh-px
Copy link
Contributor Author

harsh-px commented Jun 12, 2018 •
edited
Loading

@davidz627 All tests are passing. can you review this? Thanks.

@davidz627
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2018
@davidz627
Copy link
Contributor

/assign @jsafrane

@harsh-px
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, harsh-px, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2018
@harsh-px
Copy link
Contributor Author

The review has been approved and all tests are passing. Can I get some help getting this merged?

@jsafrane
Copy link
Member

It's code freeze time, only approved bugfixes get in. Please be patient.

@harsh-px
Copy link
Contributor Author

@jsafrane sure. What is the process to get this approved? This is an important bug fix as it causes a panic. So I wanted to get this in asap.

@jsafrane jsafrane closed this Jun 18, 2018
@jsafrane
Copy link
Member

sorry, wrong button

@jsafrane jsafrane reopened this Jun 18, 2018
@jsafrane
Copy link
Member

/sig storage
/kind bug
/priority important-soon

@saad-ali, @childsb, please approve and add 1.11 milestone, this fixes a panic in portworx plugin.

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/bug Categorizes issue or PR as related to a bug. labels Jun 18, 2018
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 18, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@harsh-px
Copy link
Contributor Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64895, 64938, 63700, 65050, 64957). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f042180 into kubernetes:master Jun 21, 2018
@k8s-ci-robot
Copy link
Contributor

@harsh-px: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big b5234d3 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-e2e-gce b5234d3 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Jun 28, 2018
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 3, 2018
Merge pull request #65591 from harsh-px/automated-cherry-pick-of-#648…
2facc7d 
…95-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #64895: In case storage class parameters are empty, create a new map

Cherry pick of #64895 on release-1.9.

#64895: In case storage class parameters are empty, create a new map
k8s-github-robot pushed a commit that referenced this pull request Jul 4, 2018
Merge pull request #65590 from harsh-px/automated-cherry-pick-of-#648…
8b28a02 
…95-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #64895: In case storage class parameters are empty, create a new map

Cherry pick of #64895 on release-1.10.

#64895: In case storage class parameters are empty, create a new map
@harsh-px harsh-px mentioned this pull request Oct 16, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 8, 2018
@k8s-ci-robot
Merge pull request #69899 from harsh-px/automated-cherry-pick-of-#648…
3290824 
…95-upstream-release-1.11

Automated cherry pick of #64895: In case storage class parameters are empty, create a new map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@verult verult Awaiting requested review from verult

Assignees

@jsafrane jsafrane

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harsh-px @davidz627 @jsafrane @k8s-ci-robot @k8s-github-robot