Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #66007: Return vmUUID when renewing nodeinfo in VCP #66444

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Automated cherry pick of #66007: Return vmUUID when renewing nodeinfo in VCP #66444

merged 1 commit into from
Jul 30, 2018

Conversation

redbaron
Copy link
Contributor

Cherry pick of #66007 on release-1.10.

#66007: Return vmUUID when renewing nodeinfo in VCP

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 20, 2018
@redbaron
Copy link
Contributor Author

/sig vmware

@k8s-ci-robot k8s-ci-robot added the area/provider/vmware Issues or PRs related to vmware provider label Jul 20, 2018
@redbaron
Copy link
Contributor Author

cc @divyenpatel @dougm

divyenpatel
divyenpatel approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2018
@dougm
Copy link
Member

dougm commented Jul 20, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, dougm, redbaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redbaron
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@redbaron: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dougm
Copy link
Member

dougm commented Jul 20, 2018

/ok-to-test

@redbaron faster to just re-run the specific test that failed instead of retest all:

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2018
@redbaron
Copy link
Contributor Author

@redbaron: The following test failed, say /retest to rerun them all:

I read it as /retest is going to retest only failing tests listed in the table, will do individual retests next time

@dougm
Copy link
Member

dougm commented Jul 20, 2018

@redbaron ah nice, I'd only used 'retest' once a while back and thought it had re-run every test.

@redbaron
Copy link
Contributor Author

redbaron commented Jul 20, 2018 •
edited

Who can merge it? Fingers crossed, it can go in time before 1.10.6 :)

@dougm
Copy link
Member

dougm commented Jul 20, 2018

The 1.10 release patch manager will triage all PRs with the do-not-merge/cherry-pick-not-approved label.

@dougm
Copy link
Member

dougm commented Jul 20, 2018

Note that this has also been cherry picked to the 1.11 branch #66147

@MaciekPytel
Copy link
Contributor

Looks good, but this cherry-pick was opened past deadline for 1.10.6. Currently I'm only cherry-picking PRs that fix release-blocking tests, so we can get the release going. Please ping me if you think this is critical for 1.10.6, otherwise I'll merge it after the release.

@redbaron
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 30, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit bfa3c54 into kubernetes:release-1.10 Jul 30, 2018
@redbaron redbaron deleted the automated-cherry-pick-of-#66007-upstream-release-1.10 branch July 30, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyenpatel divyenpatel divyenpatel approved these changes

@pmorie pmorie Awaiting requested review from pmorie

@thockin thockin Awaiting requested review from thockin

Assignees

@divyenpatel divyenpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/vmware Issues or PRs related to vmware provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@redbaron @dougm @k8s-ci-robot @MaciekPytel @k8s-github-robot @divyenpatel @w-leads