Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return vmUUID when renewing nodeinfo in VCP #66007

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Return vmUUID when renewing nodeinfo in VCP #66007

merged 1 commit into from
Jul 12, 2018

Conversation

w-leads
Copy link
Contributor

@w-leads w-leads commented Jul 10, 2018 •
edited

What this PR does / why we need it:
This PR fixes an issue that VM UUID is removed when renewing node information in vSphere cloud provider

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Preserve vmUUID when renewing nodeinfo in vSphere cloud provider

/sig vmware

@k8s-ci-robot k8s-ci-robot added area/provider/vmware Issues or PRs related to vmware provider do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 10, 2018
@w-leads
Copy link
Contributor Author

w-leads commented Jul 10, 2018 •
edited

I'm not 100% sure, but this issue may be related to #65933

@w-leads
Copy link
Contributor Author

w-leads commented Jul 10, 2018

/assign @dougm

@dougm
Copy link
Member

dougm commented Jul 10, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2018
@dougm
Copy link
Member

dougm commented Jul 10, 2018

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-100-performance

@shahbour
Copy link

@w-leads hope it is the issue with #65933, is their a way to manually test this or some workaround to test it ?

@dougm
Copy link
Member

dougm commented Jul 10, 2018

/approve

Looks like this was also an issue prior to 1.11. Looks like the renew logic did not set vmUUID when it was introduced in 25b1cd4 , @prashima can you PTAL?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2018
@dougm
Copy link
Member

dougm commented Jul 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougm, w-leads

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 66122, 66007). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d2696d5 into kubernetes:master Jul 12, 2018
@dougm dougm mentioned this pull request Jul 13, 2018
Merged
@dougm
Copy link
Member

dougm commented Jul 13, 2018

Created cherry pick PR #66147 for 1.11.1 consideration.

@w-leads
Copy link
Contributor Author

w-leads commented Jul 13, 2018

@dougm Thank you for reviewing and creating cherry pick!

@dougm
Copy link
Member

dougm commented Jul 13, 2018

@w-leads Thank you for the fix!

Can you add the cherry pick release-note Preserve vmUUID when renewing nodeinfo in vSphere cloud provider to this PR? I'm not able to edit the summary.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 13, 2018
@k8s-ci-robot k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Jul 13, 2018
@w-leads
Copy link
Contributor Author

w-leads commented Jul 13, 2018

@dougm Sure, I added the release note to this PR

@dougm
Copy link
Member

dougm commented Jul 13, 2018

Great, thanks @w-leads

@dougm
Copy link
Member

dougm commented Jul 13, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 13, 2018
k8s-github-robot pushed a commit that referenced this pull request Jul 19, 2018
Merge pull request #66147 from dougm/automated-cherry-pick-of-#66007-…
248728c 
…upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #66007: Return vmUUID when renewing nodeinfo in VCP

Cherry pick of #66007 on release-1.11.

#66007: Return vmUUID when renewing nodeinfo in VCP

```release-note
Preserve vmUUID when renewing nodeinfo in vSphere cloud provider
```
@redbaron redbaron mentioned this pull request Jul 20, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 30, 2018
Merge pull request #66444 from redbaron/automated-cherry-pick-of-#660…
bfa3c54 
…07-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #66007: Return vmUUID when renewing nodeinfo in VCP

Cherry pick of #66007 on release-1.10.

#66007: Return vmUUID when renewing nodeinfo in VCP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dougm dougm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/vmware Issues or PRs related to vmware provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@w-leads @dougm @shahbour @k8s-ci-robot @k8s-github-robot