Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #61459: etcd client add dial timeout #68124

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Automated cherry pick of #61459: etcd client add dial timeout #68124

merged 1 commit into from
Sep 25, 2018

Conversation

tossmilestone
Copy link
Member

@tossmilestone tossmilestone commented Aug 31, 2018 •
edited

Cherry pick of #61459 on release-1.9.

#61459: etcd client add dial timeout

Fix #62538

kube-apiserver now sets a dial timeout when connecting to etcd, to allow it to tolerate/retry connections to a dead etcd server

@k8s-ci-robot
Copy link
Contributor

@tossmilestone:
This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.
To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.
The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2018
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 31, 2018
@tossmilestone
Copy link
Member Author

/assign @lavalamp

@idealhack
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 31, 2018
@tossmilestone
Copy link
Member Author

/assign @timothysc @hzxuzhonghu

@hzxuzhonghu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2018
@tossmilestone
Copy link
Member Author

/assign @mbohlool

@idealhack
Copy link
Member

/assign @liggitt @wojtek-t

@timothysc timothysc removed their assignment Sep 7, 2018
@mbohlool
Copy link
Contributor

release tool will gather release notes from original PRs, please move the release note there.

@tossmilestone
Copy link
Member Author

@mbohlool the original pr already has the release note

@mbohlool
Copy link
Contributor

sorry for my vague comment. I was trying to see if you can move the release-note from this PR to the original PR as that is the one that counts. will try to do it myself.

@tossmilestone
Copy link
Member Author

@mbohlool thanks for your help! 😄

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 25, 2018
@mbohlool mbohlool added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: hzxuzhonghu, tossmilestone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5df609d into kubernetes:release-1.9 Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@lavalamp lavalamp

@liggitt liggitt

@mbohlool mbohlool

@wojtek-t wojtek-t

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@tossmilestone @k8s-ci-robot @idealhack @hzxuzhonghu @mbohlool @timothysc @lavalamp @liggitt @wojtek-t