Upgraded e2e/apimachinery/aggregator to 1.10 Sample API server

[yliaog]

What this PR does / why we need it:
Upgraded the e2e test "Should be able to support the 1.10 Sample API Server using the current Aggregator" from 1.7

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #63622

Special notes for your reviewer:

Release note:

[yliaog]

/sig api-machinery

[dims]

/hold

@yliaog how can the sample-apiserver image be kubernetes 1.9 based? the Dockerfile still has not been updated! did someone push a image without a change being merged in k/k repository?

https://github.com/kubernetes/kubernetes/blob/master/test/images/sample-apiserver/Dockerfile#L26

[fedebongio]

@dims yes, that's my fault - I've generated and uploaded the image while I was working on upgrading the test, the yliao took over, but the image was uploaded. I'll fix it soon.

[fedebongio]

That said, we also discussed having a test for 1.9, another one for 1.10, and so on for at least the -2 versions we support by policy. So in your opinion, which version should be in the master docker file?

[dims]

@fedebongio i am good whatever you all come up with :) (logically the image name should probably have version number of k/ and the docker file should probably start from 1.0 and get bumped when the image gets updated.)

[fedebongio]

/assign @fedebongio

[k8s-ci-robot]

@fedebongio: GitHub didn't allow me to assign the following users: fedebongio.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @fedebongio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ixdy]

1.9 is about to become unsupported once 1.12 is released. should we be targeting something newer?

[fedebongio]

I think the ideal is to have a test for the 3 supported versions that we support for policy. And yes, this is taking so long, that by the time we merge this one, will be deprecated (will always be better than 1.7...).

[fedebongio]

Submitting #68545

[yliaog]

/cc @cheftako

[spiffxp]

/retest

[yliaog]

Depend on #69239

[yliaog]

after some in-depth investigations, it turns out the 1.10 sample-apiserver would need the following rbac permissions (in addition to the system:auth-delegator role). I'm updating the PR to add these.

================================
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: sample-apiserver
rules:

• apiGroups:
  • admissionregistration.k8s.io
    resources:
  • '*'
    verbs:
  • list
• apiGroups:
  • ''
    resources:
  • namespaces
    verbs:
  • list

[yliaog]

/retest

[yliaog]

/retest

[cheftako]

/lgtm

[yliaog]

/remove hold

[yliaog]

/hold cancel

[cheftako]

/approve

[janetkuo]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, janetkuo, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [janetkuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yliaog]

/retest

[yliaog]

/retest