Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple arguments for cordon and drain #68655

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Support multiple arguments for cordon and drain #68655

merged 1 commit into from
Nov 15, 2018

Conversation

goodluckbot
Copy link
Contributor

@goodluckbot goodluckbot commented Sep 14, 2018 •
edited

What this PR does / why we need it:
Support multiple arguments for cordon/uncordon and drain

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68630

Special notes for your reviewer:

Release note:

kubectl: support multiple arguments for cordon/uncordon and drain

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/kubectl needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 14, 2018
@neolit123
Copy link
Member

@goodluckbot
thanks for the PR!

please change the release note in the first post to:

kubectl: support multiple arguments for cordon/uncordon and drain

/hold
/ok-to-test
/kind bug

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 14, 2018
@goodluckbot
Copy link
Contributor Author

goodluckbot commented Sep 14, 2018 •
edited

Thanks @neolit123 , updated the release note

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2018
@Antiarchitect
Copy link

@goodluckbot please update if possible.

@goodluckbot
Copy link
Contributor Author

@Antiarchitect yea, let me try to do it today.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 11, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 11, 2018
@neolit123
Copy link
Member

/check-cla

@neolit123
Copy link
Member

please sign the CLA as instructed here:
#68655 (comment)

if you encounter issues with that please contact the CNCF help desk.

@k8s-ci-robot k8s-ci-robot removed sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/gcp sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Nov 12, 2018
@goodluckbot
Copy link
Contributor Author

goodluckbot commented Nov 12, 2018 •
edited

/remove-area apiserver
/remove-area kubeadm
/remove-area kubelet
/remove-kind documentation

@k8s-ci-robot
Copy link
Contributor

@goodluckbot: Those labels are not set on the issue: area/apiserver, area/kubeadm, area/kubelet

In response to this:

/remove-area apiserver
/remove-area kubeadm
/remove-area kubelet
/remove-kind documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the kind/documentation Categorizes issue or PR as related to documentation. label Nov 12, 2018
@goodluckbot
Copy link
Contributor Author

@smarterclayton can you please take a look? thanks!

@smarterclayton
Copy link
Contributor

Yay!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@smarterclayton smarterclayton added this to the v1.13 milestone Nov 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goodluckbot, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2018
@smarterclayton smarterclayton removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 14, 2018 •
edited

@goodluckbot: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e 597e43d7d434b7c6ce8336fda2e96de2fabe6d7a link /test pull-kubernetes-local-e2e
pull-kubernetes-local-e2e-containerized 041b715751c78108feb344b628bc06219ea6582c link /test pull-kubernetes-local-e2e-containerized
pull-kubernetes-e2e-gke 041b715751c78108feb344b628bc06219ea6582c link /test pull-kubernetes-e2e-gke
pull-kubernetes-cross 041b715751c78108feb344b628bc06219ea6582c link /test pull-kubernetes-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@goodluckbot
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 012a438 into kubernetes:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eparis eparis Awaiting requested review from eparis

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

cordon and drain should take multiple arguments
6 participants
@goodluckbot @neolit123 @Antiarchitect @k8s-ci-robot @smarterclayton @fejta-bot