Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently print errors to stderr and add newlines to cordon #68656

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Consistently print errors to stderr and add newlines to cordon #68656

merged 1 commit into from
Oct 17, 2018

Conversation

smarterclayton
Copy link
Contributor 

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 14, 2018
@smarterclayton
Copy link
Contributor Author

@kubernetes/sig-cli-bugs

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 14, 2018
@smarterclayton
Copy link
Contributor Author

Wow, the drain test cases are a bit of a horror show of internal types and using the wrong codecs. Going to have to fix that.

@smarterclayton
Copy link
Contributor Author

I unfortunately had to work around the scheme problem, it was more involved than I expected.

@juanvallejo looks like the drain tests were broken when we switched to external types, but no one noticed because we never printed the error output. We need to fix drain to work with an external scheme that doesn't use legacy, but it's more involved. Can you make sure there is a sig-cli work item to cover this test? I can file an issue.

@dims
Copy link
Member

dims commented Sep 18, 2018

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims September 18, 2018 12:53
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2018
@smarterclayton
Copy link
Contributor Author

bazel i hate you

@dims
Copy link
Member

dims commented Sep 18, 2018

LOL, this time it's not bazel's fault :) need to update drain_test.go i think

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2018
@smarterclayton
Copy link
Contributor Author

It was Bazel's fault, the way we build inside bazel is slightly different than the way outside, which causes different error messages to show up

@dims
Copy link
Member

dims commented Sep 19, 2018

aha! thanks @smarterclayton

@smarterclayton
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2018
soltysh
soltysh approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@soltysh
Copy link
Contributor

soltysh commented Oct 16, 2018

/retest

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Oct 16, 2018 via email

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit ce7e7e3 into kubernetes:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@smarterclayton @k8s-ci-robot @dims @soltysh @fejta-bot