Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Node.Spec.Unschedulable when TaintNodeByCondition is GA'ed #69010

Closed
3 tasks
bsalamat opened this issue Sep 24, 2018 · 16 comments
Closed
3 tasks

Deprecate Node.Spec.Unschedulable when TaintNodeByCondition is GA'ed #69010

bsalamat opened this issue Sep 24, 2018 · 16 comments
Assignees
@draveness
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@bsalamat
Copy link
Member

TaintNodeByCondition has replaced the existing node condition. With this feature node conditions that affect feasibility of nodes are reflected as taints on nodes. This feature is promoted to Beta in 1.12. We should deprecate node conditions once the feature is GA'ed in future releases.

  • Announce deprecation of Node.Spec.Unschedulable
  • Mark Node.Spec.Unschedulable as deprecated in our API
  • Update our documents to note that Node.Spec.Unschedulable is deprecated

/sig scheduling
/sig node
@bsalamat bsalamat added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Sep 24, 2018
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 24, 2018
@bsalamat
Copy link
Member Author

/xref #68984

@k82cn k82cn mentioned this issue Sep 25, 2018
Merged
@tianshapjq tianshapjq mentioned this issue Sep 25, 2018
Closed
@tianshapjq
Copy link
Contributor

hi~ I am interested in this job, and commit a pr to give it a try. Would you please take a look to check if I do it right? :)

@bsalamat
Copy link
Member Author

@tianshapjq Thanks for the PR, but as it is mentioned in the issue, we should deprecate Node.Spec.Unschedulable only when TaintNodeByCondition is GA. TaintNodeByCondition is beta in 1.12 and will probably not be in GA in 1.13. So, there will be some time before we can deprecate Node.Spec.Unschedulable.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2018
@Huang-Wei
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 24, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 23, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness
Copy link
Contributor

/reopen
/remove-lifecycle rotten
/assign

@k8s-ci-robot
Copy link
Contributor

@draveness: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jul 12, 2019
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 12, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2019
@tedyu tedyu mentioned this issue Oct 10, 2019
Closed
@tedyu
Copy link
Contributor

tedyu commented Oct 10, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2019
@draveness draveness mentioned this issue Oct 24, 2019
Closed
@draveness
Copy link
Contributor

We can't deprecate the Unschedulable field unless we have v2 node API, per discussion in #84266 (comment). We'll revisit this issue after that

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 24, 2019
@draveness
Copy link
Contributor

/close

feel free to reopen this

@k8s-ci-robot
Copy link
Contributor

@draveness: Closing this issue.

In response to this:

/close

feel free to reopen this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness draveness mentioned this issue Aug 9, 2020
Closed
@houminz houminz mentioned this issue Aug 10, 2020
Merged
This was referenced May 28, 2021
Closed
Closed
@edcdavid edcdavid mentioned this issue Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draveness draveness

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mark Node.Spec.Unschedulable deprecated tianshapjq/kubernetes
7 participants
@tedyu @Huang-Wei @draveness @bsalamat @k8s-ci-robot @tianshapjq @fejta-bot