-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update crictl to v1.12.0 #69033
Update crictl to v1.12.0 #69033
Conversation
/retest |
Test failing because of https://storage.googleapis.com/kubernetes-release/crictl/crictl-v1.12.0-linux-amd64 missing. |
@kubernetes/sig-node-bugs is this a release blocker? |
@Random-Liu Could you help to upload the file? |
/priority critical-urgent |
cluster/gce/gci/configure.sh
Outdated
DEFAULT_CRICTL_VERSION="v1.11.1" | ||
DEFAULT_CRICTL_SHA1="527fca5a0ecef6a8e6433e2af9cf83f63aff5694" | ||
DEFAULT_CRICTL_VERSION="v1.12.0" | ||
DEFAULT_CRICTL_SHA1="6c8540bff581970344d170ad2e785c5dafee5e1d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
82ef8b44849f9da0589c87e9865d4716573eec7f
ec11751
to
fa42ba6
Compare
@Random-Liu @tpepper Fixed now. PTAL |
/lgtm |
At its current rate this is unlikely to make 1.12.0. Without a bit of heroics it's going to be 1.12.1. Specifically: First, still looking for approvers:
Second, while the post-thaw merging through tide is progressing it still probably has a day to so this change wouldn't merge until late today or early tomorrow which is our release day (after delaying it). Given this was found late, it wouldn't have merged for 1.12.0 on the original planned release day. That means it's not in the master branch to be a cherry pick candidate for release-1.12 branch. I see three options here:
Pending clear direction to the 1.12 release team from the stakeholders here that we must do otherwise and folks clearly declaring one of the options above as the chosen path, my assumption moving forward is that this will be 1.12.1. |
We need to make changes https://github.com/kubernetes/release/search?q=cri-tools&unscoped_q=cri-tools too! |
/approve |
it looks like kubernetes/release#641 is the corresponding change in k/release, though it needs version-gating. |
ping @dchen1107 @yguo0905 for gci approval |
/lgtm /assign @dchen1107 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, feiskyer, ixdy, Random-Liu, yujuhong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…33-upstream-release-1.12 Automated cherry pick of #69033: Update crictl to v1.12.0
What this PR does / why we need it:
Update crictl to v1.12.0: https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.12.0.
cc @kubernetes/sig-node-pr-reviews @kubernetes/sig-cluster-lifecycle-pr-reviews
@kubernetes/sig-gcp-pr-reviews
/assign @Random-Liu @tpepper
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: