Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crictl to v1.12.0 #69033

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

feiskyer
Copy link
Member

What this PR does / why we need it:

Update crictl to v1.12.0: https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.12.0.

cc @kubernetes/sig-node-pr-reviews @kubernetes/sig-cluster-lifecycle-pr-reviews
@kubernetes/sig-gcp-pr-reviews

/assign @Random-Liu @tpepper

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Update crictl to v1.12.0

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 25, 2018
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/gcp cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 25, 2018
@feiskyer feiskyer added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Sep 25, 2018
@feiskyer
Copy link
Member Author

/retest

@tpepper
Copy link
Member

tpepper commented Sep 25, 2018

@tpepper
Copy link
Member

tpepper commented Sep 25, 2018

@kubernetes/sig-node-bugs is this a release blocker?

@feiskyer
Copy link
Member Author

feiskyer commented Sep 25, 2018

@Random-Liu Could you help to upload the file?

@tpepper tpepper added this to the v1.12 milestone Sep 25, 2018
@tpepper
Copy link
Member

tpepper commented Sep 25, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 25, 2018
DEFAULT_CRICTL_VERSION="v1.11.1"
DEFAULT_CRICTL_SHA1="527fca5a0ecef6a8e6433e2af9cf83f63aff5694"
DEFAULT_CRICTL_VERSION="v1.12.0"
DEFAULT_CRICTL_SHA1="6c8540bff581970344d170ad2e785c5dafee5e1d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

82ef8b44849f9da0589c87e9865d4716573eec7f

@feiskyer
Copy link
Member Author

@Random-Liu @tpepper Fixed now. PTAL

@Random-Liu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@tpepper
Copy link
Member

tpepper commented Sep 26, 2018

At its current rate this is unlikely to make 1.12.0. Without a bit of heroics it's going to be 1.12.1. Specifically:

First, still looking for approvers:

Second, while the post-thaw merging through tide is progressing it still probably has a day to so this change wouldn't merge until late today or early tomorrow which is our release day (after delaying it). Given this was found late, it wouldn't have merged for 1.12.0 on the original planned release day. That means it's not in the master branch to be a cherry pick candidate for release-1.12 branch.

I see three options here:

  • Delay the release again until this is merged and cherry picked. I'm not inclined to do this.
  • It's unfortunate, but since it would've already missed 1.12.0 in the original schedule, if we don't merge this, we fall back to marking it as a Known Issue in the 1.12.0 release note in 1.12 release notes: known issues bucket #68840. This is the most realistic option in my opinion.
  • If it is viewed as a release blocker, if it is merge approved here and just in the backlog for master, we could consider doing a cherry pick of the commit into release-1.12 branch but from feiskyer/kubernetes instead of from master. If folks want to consider this route, it should happen ASAP like immediately, so we still get a day's worth of CI on release-1.12 branch.

Pending clear direction to the 1.12 release team from the stakeholders here that we must do otherwise and folks clearly declaring one of the options above as the chosen path, my assumption moving forward is that this will be 1.12.1.

@dims
Copy link
Member

dims commented Sep 26, 2018

@ixdy
Copy link
Member

ixdy commented Sep 26, 2018

/approve

@ixdy
Copy link
Member

ixdy commented Sep 26, 2018

it looks like kubernetes/release#641 is the corresponding change in k/release, though it needs version-gating.

@tpepper
Copy link
Member

tpepper commented Sep 27, 2018

@feiskyer if you want this in the Known Issues for 1.12.0, please put it in ##68840

@feiskyer
Copy link
Member Author

feiskyer commented Oct 1, 2018

ping @dchen1107 @yguo0905 for gci approval

@yujuhong
Copy link
Contributor

yujuhong commented Oct 1, 2018

/lgtm

/assign @dchen1107
/assign @yguo0905

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, feiskyer, ixdy, Random-Liu, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit da5730e into kubernetes:master Oct 2, 2018
@feiskyer feiskyer deleted the crictl-update branch October 3, 2018 01:32
k8s-ci-robot added a commit that referenced this pull request Oct 5, 2018
…33-upstream-release-1.12

Automated cherry pick of #69033: Update crictl to v1.12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants