Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in kubectl rollout commands #69150

Merged
merged 2 commits into from Sep 27, 2018
Merged

Fix panic in kubectl rollout commands #69150

merged 2 commits into from Sep 27, 2018

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Sep 27, 2018

What this PR does / why we need it:
Fixes #69144 and supersedes #69148

/assign @juanvallejo @Pingan2017

Release note:

Fix panic in kubectl rollout commands

@k8s-ci-robot
Copy link
Contributor

@soltysh: GitHub didn't allow me to assign the following users: Pingan2017.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

What this PR does / why we need it:
Fixes #69144 and supersedes #69148

/assign @juanvallejo @Pingan2017

Release note:

Fix panic in kubectl rollout commands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 27, 2018
@soltysh soltysh mentioned this pull request Sep 27, 2018
Closed
@soltysh
Copy link
Contributor Author

soltysh commented Sep 27, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 27, 2018
@soltysh soltysh mentioned this pull request Sep 27, 2018
Merged
@soltysh
Copy link
Contributor Author

soltysh commented Sep 27, 2018 •
edited

I've opened 1.12 cherry-pick in #69151

@juanvallejo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 34860da into kubernetes:master Sep 27, 2018
@soltysh soltysh deleted the issue69144 branch September 28, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo approved these changes

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soltysh @k8s-ci-robot @juanvallejo @Pingan2017