New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in kubectl rollout commands #69150

Merged
merged 2 commits into from Sep 27, 2018

Conversation

@soltysh
Contributor

soltysh commented Sep 27, 2018

What this PR does / why we need it:
Fixes #69144 and supersedes #69148

/assign @juanvallejo @Pingan2017

Release note:

Fix panic in kubectl rollout commands

Pingan2017 and others added some commits Sep 27, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 27, 2018

Contributor

@soltysh: GitHub didn't allow me to assign the following users: Pingan2017.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

What this PR does / why we need it:
Fixes #69144 and supersedes #69148

/assign @juanvallejo @Pingan2017

Release note:

Fix panic in kubectl rollout commands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

k8s-ci-robot commented Sep 27, 2018

@soltysh: GitHub didn't allow me to assign the following users: Pingan2017.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

What this PR does / why we need it:
Fixes #69144 and supersedes #69148

/assign @juanvallejo @Pingan2017

Release note:

Fix panic in kubectl rollout commands

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Sep 27, 2018

Contributor

/kind bug

Contributor

soltysh commented Sep 27, 2018

/kind bug

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Sep 27, 2018

Contributor

I've opened 1.12 cherry-pick in #69151

Contributor

soltysh commented Sep 27, 2018

I've opened 1.12 cherry-pick in #69151

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Sep 27, 2018

Member

/lgtm

Member

juanvallejo commented Sep 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 27, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 27, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 34860da into kubernetes:master Sep 27, 2018

18 checks passed

cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@soltysh soltysh deleted the soltysh:issue69144 branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment