Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/scheduler/algorithm/well_known_labels.go out #69192

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Move pkg/scheduler/algorithm/well_known_labels.go out #69192

merged 1 commit into from
Oct 13, 2018

Conversation

tanshanshan
Copy link

What this PR does / why we need it:
Move pkg/scheduler/algorithm/well_known_labels.go out
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69138

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2018
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/kubelet sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 28, 2018
@tanshanshan tanshanshan changed the title Move pkg/scheduler/algorithm/well_known_labels.go out WIP Move pkg/scheduler/algorithm/well_known_labels.go out Sep 28, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2018
@krmayankk
Copy link

/assign @k4leung4 @misterikkit

@krmayankk
Copy link

is this also part of the scheduler cleanup ?

@tanshanshan
Copy link
Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 28, 2018
@tanshanshan tanshanshan changed the title WIP Move pkg/scheduler/algorithm/well_known_labels.go out Move pkg/scheduler/algorithm/well_known_labels.go out Sep 28, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2018
@misterikkit
Copy link

If this fixes an import loop problem, then I am in favor.
/lgtm

Also, these constants are used by several packages outside of scheduler. So removing their dependency on the algorithm package is a bonus.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2018
misterikkit
misterikkit approved these changes Oct 3, 2018
View reviewed changes
Copy link

@misterikkit misterikkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is a simple move of some constant strings from a package where they did not belong.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2018
@misterikkit
Copy link

@k82cn @bsalamat can one of you approve this one? Afterward, we will seek approval from other SIGs or a global approver.

@k82cn
Copy link
Member

k82cn commented Oct 3, 2018

/approve

Thanks very much for this cleanup :)

@misterikkit
Copy link

@deads2k Do you mind giving this a look? It just changes import paths.

bsalamat
bsalamat approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks, @tanshanshan! I am glad to see this clean-up.

@bsalamat
Copy link
Member

bsalamat commented Oct 4, 2018

/retest

@tanshanshan
Copy link
Author

/test pull-kubernetes-local-e2e-containerized

@misterikkit
Copy link

@derekwaynecarr @deads2k Do you have time to review these simple import changes for controller, kubelet, admission, and test?

@k82cn
Copy link
Member

k82cn commented Oct 10, 2018

/retest

@thockin
Copy link
Member

thockin commented Oct 11, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, tanshanshan, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2018
@tanshanshan
Copy link
Author

/test pull-kubernetes-e2e-gce

@k82cn
Copy link
Member

k82cn commented Oct 12, 2018

/retest

@tanshanshan
Copy link
Author

/test pull-kubernetes-integration

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@misterikkit
Copy link

Looks like this needs a rebase.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2018
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 13, 2018
misterikkit
misterikkit approved these changes Oct 13, 2018
View reviewed changes
Copy link

@misterikkit misterikkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit d82397b into kubernetes:master Oct 13, 2018
@k82cn k82cn mentioned this pull request Nov 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterikkit misterikkit misterikkit approved these changes

@bsalamat bsalamat bsalamat approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@misterikkit misterikkit

@bsalamat bsalamat

@k4leung4 k4leung4

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move pkg/scheduler/algorithm/well_known_labels.go out
9 participants
@tanshanshan @krmayankk @misterikkit @k82cn @bsalamat @thockin @k8s-ci-robot @fejta-bot @k4leung4