Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test name: s/overriden/overridden #69212

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Fix test name: s/overriden/overridden #69212

merged 1 commit into from
Oct 3, 2018

Conversation

warmchang
Copy link
Contributor

@warmchang warmchang commented Sep 28, 2018

What this PR does / why we need it:
Fix test name: s/overriden/overridden in staging/src/k8s.io/apimachinery/pkg/conversion/converter_test.go

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 28, 2018
@warmchang
Copy link
Contributor Author

warmchang commented Sep 28, 2018

/release-note-none
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 28, 2018
@nikhita
Copy link
Member

nikhita commented Sep 29, 2018

@warmchang Thanks for your PR! Can you update the PR title and commit message to reflect the change better? Something like Fix test name: s/overriden/overridden.

@warmchang warmchang changed the title Overridden 😃 Fix test name: s/overriden/overridden Sep 30, 2018
Signed-off-by: William Zhang <zhang.wanmin@zte.com.cn>
@warmchang
Copy link
Contributor Author

@nikhita Refer to your suggestion, I have completed the modification and submitted. Please check it, thanks.

@nikhita
Copy link
Member

nikhita commented Sep 30, 2018

@warmchang awesome, thank you!

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 30, 2018
@jennybuckley
Copy link

/assign @roycaihw

@roycaihw
Copy link
Member

roycaihw commented Oct 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2018
@nikhita
Copy link
Member

nikhita commented Oct 3, 2018

/assign @liggitt
for approval

@liggitt
Copy link
Member

liggitt commented Oct 3, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, roycaihw, warmchang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 49bb464 into kubernetes:master Oct 3, 2018
@warmchang warmchang deleted the apimachinery branch September 12, 2019 07:52
@warmchang warmchang restored the apimachinery branch June 6, 2020 04:49
@warmchang warmchang deleted the apimachinery branch June 6, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants