Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update addon-manager to use debian-base:0.3.2. #69315

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Update addon-manager to use debian-base:0.3.2. #69315

merged 1 commit into from
Oct 2, 2018

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Oct 1, 2018

What this PR does / why we need it:
/assign @awly @ixdy

This is similar to #67283.

The actual image bump will happen separately.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68858

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 1, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 1, 2018
@awly
Copy link
Contributor

awly commented Oct 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2018
ixdy
ixdy reviewed Oct 1, 2018
View reviewed changes
cluster/addons/addon-manager/Makefile
@@ -15,24 +15,10 @@
IMAGE=staging-k8s.gcr.io/kube-addon-manager
ARCH?=amd64
TEMP_DIR:=$(shell mktemp -d)
VERSION=v8.7
VERSION=v8.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any significance to the major/minor of this version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I should probably call it v8.7-r1?

cluster/addons/addon-manager/Dockerfile Outdated
@@ -14,6 +14,8 @@

FROM BASEIMAGE

RUN apt-get update && apt-get install -y bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use clean-install bash instead. (it's a helper script we installed in debian-base which does this and also cleans up the caches afterwards.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good to know. Updated now.

@MrHohn MrHohn force-pushed the addon-manager-debian-update branch from 4470123 to 1736800 Compare October 1, 2018 23:53
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2018
ixdy
ixdy reviewed Oct 1, 2018
View reviewed changes
cluster/addons/addon-manager/CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
### Version 8.7-r1 (Mon October 1 2018 Zihong Zheng <zihongz@google.com>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, v8.8 was fine. wasn't sure whether it merited bumping to v9, but I guess not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it. Reverted to use v8.8.

@MrHohn MrHohn force-pushed the addon-manager-debian-update branch from 1736800 to 6b949c8 Compare October 1, 2018 23:59
@ixdy
Copy link
Member

ixdy commented Oct 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Oct 2, 2018

Thanks, adding @mikedanese for approval.
/assign @mikedanese

@mikedanese
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awly, ixdy, mikedanese, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Oct 2, 2018

/retest

@MrHohn
Copy link
Member Author

MrHohn commented Oct 2, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 2, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit bcb197e into kubernetes:master Oct 2, 2018
@MrHohn MrHohn mentioned this pull request Oct 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy ixdy left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@awly awly

@mikedanese mikedanese

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update kube-addon-manager base Alpine image to 3.8.1
6 participants
@MrHohn @awly @ixdy @mikedanese @k8s-ci-robot @fejta-bot