Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes golint in test/utils/image #69680

Merged
merged 1 commit into from Oct 30, 2018
Merged

Fixes golint in test/utils/image #69680

merged 1 commit into from Oct 30, 2018

Conversation

jonfriesen
Copy link
Contributor

What this PR does / why we need it:
This change fixes the test/utils/image package golint errors.

Which issue(s) this PR fixes:
refer #68026

Special notes for your reviewer:
I renamed ImageConfig to Config to fix stuttering (eg. image.ImageConfig). I couldn't find a spot where this would break other packages. Though I'm not exactly sure what the best practice is on renaming a public struct. Guidance would be appreciated :)

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2018
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2018
@jonfriesen
Copy link
Contributor Author

I messed up the last PR pretty bad, so this is a correctly rebased version of my changes. Sorry about that.

/assign @mkumatag
/assign @ixdy

@jonfriesen
Copy link
Contributor Author

@ixdy can I please get a /ok-to-test? :)

@mkumatag
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 17, 2018
@mkumatag
Copy link
Member

@jonfriesen oops.. I see a conflict, do you mind resolving it?

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/apiserver area/kubeadm area/kubectl area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 17, 2018
@k8s-ci-robot k8s-ci-robot removed sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Oct 23, 2018
@mcrute
Copy link
Contributor

mcrute commented Oct 23, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 23, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@mcrute
Copy link
Contributor

mcrute commented Oct 25, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2018
@jonfriesen
Copy link
Contributor Author

Resolved conflicts.

@mcrute any advice to get this one merge a bit faster to avoid more conflicts?

@mcrute
Copy link
Contributor

mcrute commented Oct 29, 2018

Ping @ixdy for approval. You're an approver in both relevant owners files. Thanks!

@mcrute
Copy link
Contributor

mcrute commented Oct 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 29, 2018

/approve
/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 29, 2018
ixdy
ixdy reviewed Oct 29, 2018
View reviewed changes
test/utils/image/manifest.go Outdated Show resolved Hide resolved
@jonfriesen
Fixes golint in test/utils/image
0415ebe 
This change fixes the test/utils/image package golint errors.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonfriesen, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2018
@mcrute
Copy link
Contributor

mcrute commented Oct 30, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2018
@ixdy
Copy link
Member

ixdy commented Oct 30, 2018

/lgtm

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 76234a3 into kubernetes:master Oct 30, 2018
@jonfriesen jonfriesen deleted the fix_golint_test/utils/images branch August 24, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy ixdy left review comments

@luxas luxas Awaiting requested review from luxas

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@mcrute mcrute

@ixdy ixdy

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jonfriesen @mkumatag @k8s-ci-robot @mcrute @spiffxp @ixdy @fejta-bot