Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl: copy deployment util dependency into kubectl #69692

Merged
merged 1 commit into from
Oct 19, 2018
Merged

kubectl: copy deployment util dependency into kubectl #69692

merged 1 commit into from
Oct 19, 2018

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Oct 11, 2018

  • Copies the minimal amount of necessary deployment util code into kubectl
  • Removes dependency on controller deployment utils.

Helps address:
kubernetes/kubectl#80

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2018
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2018
@seans3
Copy link
Contributor Author

seans3 commented Oct 11, 2018

/kind cleanup
/assign

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 11, 2018
@seans3
Copy link
Contributor Author

seans3 commented Oct 11, 2018

/cc @soltysh
/cc @juanvallejo

1 similar comment
@seans3
Copy link
Contributor Author

seans3 commented Oct 11, 2018

/cc @soltysh
/cc @juanvallejo

@seans3 seans3 force-pushed the deployment-util-fix branch 2 times, most recently from a53e703 to 2e37b94 Compare October 17, 2018 17:40
soltysh
soltysh requested changes Oct 18, 2018
View reviewed changes
pkg/kubectl/history.go Outdated
kapps "k8s.io/kubernetes/pkg/kubectl/apps"
"k8s.io/kubernetes/pkg/kubectl/util/deploymentutil"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we've landed podutils, but it bothers me, how about we call this pkg/kubectl/util/deployment it'll be shorter and straightforward and doesn't repeat that nasty util word.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the directory/package to "util/deployment". But I had to use an import alias of "deploymentutil" because there were collisions with variables named "deployment". Please let me know what you think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the directory/package to "util/deployment". But I had to use an import alias of "deploymentutil" because there were collisions with variables named "deployment"

I think that's fine 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, aliases are fine, I cared only about the package naming itself. Thanks!

@soltysh soltysh mentioned this pull request Oct 18, 2018
Merged
@seans3
Copy link
Contributor Author

seans3 commented Oct 18, 2018

/retest

soltysh
soltysh approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 34196ac into kubernetes:master Oct 19, 2018
@seans3 seans3 deleted the deployment-util-fix branch October 19, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@juanvallejo juanvallejo juanvallejo approved these changes

@ericchiang ericchiang Awaiting requested review from ericchiang

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seans3 @k8s-ci-robot @soltysh @juanvallejo