-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in CHANGELOG-1.10.md #69693
Conversation
@posquit0: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/assign @thockin |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: posquit0, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest
…On Tue, Oct 16, 2018 at 11:27 AM k8s-ci-robot ***@***.***> wrote:
@posquit0 <https://github.com/posquit0>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-integration 340bd8b
<340bd8b>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69693/pull-kubernetes-integration/31168/> /test
pull-kubernetes-integration
Full PR test history <https://k8s-gubernator.appspot.com/pr/69693>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/posquit0>. Please
help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#69693 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0DeUrz1RySb8Kkf030BWbV-CQfWZks5ulXU8gaJpZM4XYLxi>
.
|
/retest
…On Tue, Oct 16, 2018 at 12:03 PM k8s-ci-robot ***@***.***> wrote:
@posquit0 <https://github.com/posquit0>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-integration 340bd8b
<340bd8b>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69693/pull-kubernetes-integration/31171/> /test
pull-kubernetes-integration
Full PR test history <https://k8s-gubernator.appspot.com/pr/69693>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/posquit0>. Please
help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#69693 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0JAdoJxjk1CuCE4mkJ1RHQ6wo9CHks5ulX26gaJpZM4XYLxi>
.
|
/retest
…On Tue 16 Oct, 2018, 12:26 PM k8s-ci-robot, ***@***.***> wrote:
@posquit0 <https://github.com/posquit0>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-integration 340bd8b
<340bd8b>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69693/pull-kubernetes-integration/31173/> /test
pull-kubernetes-integration
Full PR test history <https://k8s-gubernator.appspot.com/pr/69693>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/posquit0>. Please
help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#69693 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0NvERrT3UNmMfyJ-yJvXLuQaaBBSks5ulYMTgaJpZM4XYLxi>
.
|
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: