Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license header to non-generated proto files #70440

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Add license header to non-generated proto files #70440

merged 1 commit into from
Nov 29, 2018

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Oct 30, 2018

As a part of kubernetes/sig-release#223.
/sig release
/kind cleanup

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 30, 2018
@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 30, 2018
nikhita
nikhita commented Oct 30, 2018
View reviewed changes
pkg/kubelet/apis/cri/runtime/v1alpha2/api.proto
@@ -1,3 +1,19 @@
/*
Copyright 2018 The Kubernetes Authors.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was added in 2018: #58973.

nikhita
nikhita commented Oct 30, 2018
View reviewed changes
pkg/kubelet/util/pluginwatcher/example_plugin_apis/v1beta1/api.proto
@@ -1,3 +1,19 @@
/*
Copyright 2018 The Kubernetes Authors.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was added in 2018: #63328.

nikhita
nikhita commented Oct 30, 2018
View reviewed changes
pkg/kubelet/util/pluginwatcher/example_plugin_apis/v1beta2/api.proto
@@ -1,3 +1,19 @@
/*
Copyright 2018 The Kubernetes Authors.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was added in 2018: #63328.

nikhita
nikhita commented Oct 30, 2018
View reviewed changes
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/v1beta1/service.proto
@@ -1,3 +1,19 @@
/*
Copyright 2018 The Kubernetes Authors.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was added in 2018: #55684.

@justinsb
Copy link
Member

/lgtm

Looks good - are you also fixing up the header validation checks so this doesn't happen again @nikhita ? I'm happy to (try) if you're not working on it...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2018
@nikhita
Copy link
Member Author

nikhita commented Oct 30, 2018

Looks good - are you also fixing up the header validation checks so this doesn't happen again @nikhita ? I'm happy to (try) if you're not working on it...

There is a hack/verify-boilerplate.sh script present, but I think it somehow missed these because these are .proto files but are not generated. I'll look into fixing the script. 👍

@nikhita
Copy link
Member Author

nikhita commented Oct 30, 2018

/cc @justaugustus @dims @swinslow

@k8s-ci-robot
Copy link
Contributor

@nikhita: GitHub didn't allow me to request PR reviews from the following users: swinslow.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @justaugustus @dims @swinslow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita
Copy link
Member Author

nikhita commented Oct 30, 2018

@justinsb btw, thanks for the quick lgtm! :)

@swinslow
Copy link

lgtm

thanks nikhita!

@justaugustus
Copy link
Member

/lgtm
/approve

@mbohlool
Copy link
Contributor

mbohlool commented Nov 1, 2018

/assign

@justaugustus
Copy link
Member

This looks like it's ready for approval.
/assign @tallclair @timothysc

timothysc
timothysc approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@justaugustus
Copy link
Member

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 14, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 19, 2018
@AishSundar
Copy link
Contributor

@nikhita @timothysc @tallclair how critical is this for 1.13? we are in code freeze and if possible, I would like to defer this until 1.14. let me know otherwise

/remove-priority critical-urgent

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 19, 2018
@AishSundar
Copy link
Contributor

/remove-priority critical-urgent

@k8s-ci-robot
Copy link
Contributor

@AishSundar: Those labels are not set on the issue: priority/critical-urgent

In response to this:

/remove-priority critical-urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

Sounds good, @AishSundar

@AishSundar
Copy link
Contributor

/milestone v1.14

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.13, v1.14 Nov 19, 2018
@nikhita
Copy link
Member Author

nikhita commented Nov 19, 2018

Yeah, this can wait. I'll look into fixing the script till then.

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 20, 2018
@timothysc timothysc added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 26, 2018
@timothysc timothysc removed their assignment Nov 26, 2018
@tallclair
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, nikhita, tallclair, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit d0ac922 into kubernetes:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@mqliang mqliang Awaiting requested review from mqliang

@vishh vishh Awaiting requested review from vishh

@justaugustus justaugustus Awaiting requested review from justaugustus

@dims dims Awaiting requested review from dims

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@justinsb justinsb

@justaugustus justaugustus

@mbohlool mbohlool

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nikhita @justinsb @k8s-ci-robot @swinslow @justaugustus @mbohlool @AishSundar @tallclair @timothysc