Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to sigs.k8s.io/yaml from ghodss/yaml #70598

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Switch to sigs.k8s.io/yaml from ghodss/yaml #70598

merged 1 commit into from
Nov 8, 2018

Conversation

dims
Copy link
Member

@dims dims commented Nov 2, 2018

Change-Id: Ic72b5131bf441d159012d67a6a3d87088d0e6d31

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We now have a new repository named sigs.k8s.io/yaml which has the code forked from ghodss/yaml

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/kubeadm area/kubectl kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 2, 2018
@dims dims changed the title [WIP] Switch to sigs.k8s.io/yaml from ghodss/yaml Switch to sigs.k8s.io/yaml from ghodss/yaml Nov 2, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2018
@dims
Copy link
Member Author

dims commented Nov 2, 2018

/test pull-kubernetes-integration

@dims
Copy link
Member Author

dims commented Nov 2, 2018

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 2, 2018
@dims
Copy link
Member Author

dims commented Nov 3, 2018

/test pull-kubernetes-integration

@neolit123
Copy link
Member

/lgtm

@dims
Copy link
Member Author

dims commented Nov 3, 2018

/assign @thockin

timothysc
timothysc approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@dims
Copy link
Member Author

dims commented Nov 6, 2018

/assign @thockin

@timothysc
Copy link
Member

/assign @jbeda

@jbeda
Copy link
Contributor

jbeda commented Nov 7, 2018

/approve

@dims dims force-pushed the switch-from-sigs.k8s.io/yaml-to-ghodss/yaml branch from 5ad8b05 to e5bbee0 Compare November 7, 2018 15:25
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 7, 2018
@dims
Copy link
Member Author

dims commented Nov 7, 2018

/assign @cblecker
/assign @sttts

cblecker
cblecker reviewed Nov 7, 2018
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase required
/approve

Godeps/Godeps.json Outdated
@@ -26,12 +26,12 @@
},
{
"ImportPath": "cloud.google.com/go/compute/metadata",
"Comment": "v0.1.0-115-g3b1ae45",
"Comment": "v0.1.0-115-g3b1ae453",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these comment changes? (will hopefully be resolved once and for all soon)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@dims
Switch to sigs.k8s.io/yaml from ghodss/yaml
43f523d 
Change-Id: Ic72b5131bf441d159012d67a6a3d87088d0e6d31
@dims dims force-pushed the switch-from-sigs.k8s.io/yaml-to-ghodss/yaml branch from e5bbee0 to 43f523d Compare November 7, 2018 18:18
@cblecker
Copy link
Member

cblecker commented Nov 7, 2018

/lgtm
/approve

🚀 🏆

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2018
@dims
Copy link
Member Author

dims commented Nov 8, 2018

@smarterclayton @liggitt @thockin - can you please /approve (for staging/src/k8s.io/apimachinery/pkg/apis/OWNERS)

@liggitt
Copy link
Member

liggitt commented Nov 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, jbeda, liggitt, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit f212b9d into kubernetes:master Nov 8, 2018
@neolit123
Copy link
Member

neolit123 commented Nov 8, 2018 •
edited

logo

@liggitt liggitt removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker left review comments

@timothysc timothysc timothysc approved these changes

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@jbeda jbeda

@timothysc timothysc

@neolit123 neolit123

@sttts sttts

@liggitt liggitt

@cblecker cblecker

@thockin thockin

@deads2k deads2k

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubeadm area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet