Add Release information to each of the conformance tests. #70626
Conversation
|
@brahmaroutu: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
cncf-cla: yes
|
Fix required for cncf/k8s-conformance#366 |
|
/assign @cheftako |
k8s-ci-robot
added
release-note-none
brahmaroutu
force-pushed
the
conformamce_fix_releasetag
branch
from
27cb2b4
to
8c85316
Compare
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
brahmaroutu
force-pushed
the
conformamce_fix_releasetag
branch
from
8c85316
to
85320a6
Compare
|
Sample output:
You've got an extra colon There are also tests that don't appear to have a release entry, I feel like we should display something other than blank, ie:
|
|
/approve |
|
ping @cheftako |
test/conformance/walk.go
Outdated
| @@ -72,6 +72,8 @@ type conformanceData struct { | |||
| TestName string | |||
| // Extracted from the "Description:" comment before the test | |||
| Description string | |||
| // Version when this test is added or modified ex: 1.12, 1.13 | |||
There was a problem hiding this comment.
Probably worth being consistent and documenting the extraction prefix.
test/conformance/walk.go
Outdated
| if strings.HasPrefix(line, "Testname:") { | ||
| line = strings.TrimSpace(line[9:]) | ||
| cd.TestName = line | ||
| if sline := regexp.MustCompile("Testname\\s*:\\s*").Split(line, -1); len(sline) == 2 { |
There was a problem hiding this comment.
For correctness and to maintain behavior with HasPrefix should we use the start of line indicator?
(Eg. "^Testname\s*:\s*" )
There was a problem hiding this comment.
I agree, it has to be the start of the line, fixed.
| continue | ||
| } | ||
| if sline := regexp.MustCompile("Description\\s*:\\s*").Split(line, -1); len(sline) == 2 { | ||
| line = sline[1] | ||
| } | ||
| cd.Description += line + "\n" |
There was a problem hiding this comment.
Are we concerned that newer test files with older walk code will treat newer fields as descriptions?
There was a problem hiding this comment.
Not really, we just add every other line in the comment block under the description after extracting the lines that has Testname and Version information.
brahmaroutu
force-pushed
the
conformamce_fix_releasetag
branch
from
0226e59
to
932a997
Compare
k8s-ci-robot
removed
the
lgtm
|
/test pull-kubernetes-e2e-kops-aws |
|
/test pull-kubernetes-e2e-kops-aws |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
@brahmaroutu #70626 (comment) remains unaddressed (the issue you opened to address this has aged out: #71627) Should we still be pushing on this, or close out and try something else? |
brahmaroutu
force-pushed
the
conformamce_fix_releasetag
branch
from
932a997
to
37e7000
Compare
k8s-ci-robot
added
area/test
and removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brahmaroutu, cheftako, duglin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Since 1.12 we have added a tag named 'Release' as part of conformance documentation this helps to track when a e2e test is added to conformance suite or when a test is modified.
This PR is to print the Release information into the conformance document.