Remove runtime.VersionedObject from universal apimachinery

[yue9944882]

we have a lot of legacy code supportingruntime.VersionedObjectwhile actually it's completely unused for several releases. removing this makes the decoder much cleaner.

/sig api-machinery
/kind cleanup

Does this PR introduce a user-facing change?:

NONE

[justinsb]

My understanding is that because this is in staging, this is possibly part of a public API. So I don't think we can be sure that VersionedObjects is unused just because it isn't used in k/k.

However, I agree with you that it certainly looks like it isn't something that would be used by production code (it feels like a debug/diagnostics tool)

[yue9944882]

So I don't think we can be sure that VersionedObjects is unused just because it isn't used in k/k.

@justinsb yeah i suppose thats the exact reason why this definition has been kept in k/k for several releases. but it definitely makes the decoders (json/protobuf/versioning) difficult to understand (which is the motivation of this pull 😅).

@kubernetes/api-approvers could u shed some light on whether to prune this from k/k?

[bgrant0607]

@lavalamp or @deads2k probably know

[roycaihw]

cc @mbohlool

[deads2k]

/hold

I'd like time to investigate this one.

[deads2k]

I'm really not sure. I'm not sure I'd take the risk at this point in the release.

@smarterclayton @lavalamp think we're just falling back to a different path? I don't remember history here.

[smarterclayton]

This was for generic Cli commands that needed the internal version. There was some discussion about using it in the rest storage, but I don’t think we ever did.

I’m favor of removing this but not in 1.13. Have you done a GitHub sweep to identify possible callers?

[yue9944882]

Have you done a GitHub sweep to identify possible callers?

didnt find any go project using runtime.VersionedObject. mystery huh.🤔

[lavalamp]

This is a confusing type and if we can delete it, we should, esp. while we don't offer compatibility guarantees for the apimachinery library.

I agree with the others that we should wait until after the release though.

[yue9944882]

the question again for runtime.NestedObjectEncoder. wdyt if we prune that together?

[liggitt]

the question again for runtime.NestedObjectEncoder. wdyt if we prune that together?

that's not as clear. at one time, that was required for encoding of objects containing runtime.Object fields to convert them to runtime.RawExtension

See discussion in the PR where it was added: #26044 (comment)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[yue9944882]

/remove-lifecycle stale
/lifecycle frozen

[ncdc]

/uncc

[liggitt]

can this be revived? I'd like to simplify as much here as we can, and I haven't seen any evidence of use here

[yue9944882]

sure reviving 👨🏼‍🔬

[deads2k]

I don't seem immediate issues. I forgot about this, sorry.

/hold cancel

[fejta-bot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[liggitt]

/retest

[liggitt]

/test all

[liggitt]

/lgtm
/approve
/priority backlog

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apimachinery/pkg/OWNERS [liggitt]
• staging/src/k8s.io/apimachinery/pkg/apis/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@yue9944882: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-kops-aws	a89c40cff8a6902a6b9271626de71fb6c4e9756f	link	/test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.