Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for file exec #70756

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Add e2e test for file exec #70756

merged 2 commits into from
Nov 30, 2018

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Nov 7, 2018 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Adds test case for file exec from a volume.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 7, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 7, 2018

@kubernetes/sig-storage-pr-reviews

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 7, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 8, 2018

cc @mkimuram I refactored the DriverInfo to add a capabilities map

@msau42 msau42 mentioned this pull request Nov 8, 2018
Merged
@msau42
Copy link
Member Author

msau42 commented Nov 8, 2018

cc @verult for plugin capabilities

@msau42
Copy link
Member Author

msau42 commented Nov 8, 2018

/hold
This is failing on pd csi driver

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2018
davidz627
davidz627 reviewed Nov 8, 2018
View reviewed changes
test/e2e/storage/testsuites/volumes.go Show resolved Hide resolved
test/e2e/storage/testsuites/volumes.go Show resolved Hide resolved
test/e2e/storage/testsuites/volumes.go Outdated Show resolved Hide resolved
test/e2e/storage/testsuites/volumes.go Outdated Show resolved Hide resolved
test/e2e/storage/testsuites/volumes.go Show resolved Hide resolved
@msau42 msau42 force-pushed the add-io-exec-test branch 2 times, most recently from b4d2df3 to 38e568f Compare November 15, 2018 01:45
@msau42
Copy link
Member Author

msau42 commented Nov 15, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 15, 2018
@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2018
@davidz627
Copy link
Contributor

@AishSundar test addition only, would be good to add to v1.13

@msau42 msau42 mentioned this pull request Nov 26, 2018
Merged
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@msau42
Copy link
Member Author

msau42 commented Nov 29, 2018

/lgtm cancel
I think I need to rebase

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 29, 2018

Rebased and fixed the new v0 hostpath DriverInfo

@davidz627
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 29, 2018

/test pull-kubernetes-node-e2e

@msau42
Copy link
Member Author

msau42 commented Nov 29, 2018

/test pull-kubernetes-integration

@davidz627
Copy link
Contributor

/retest
seems like this test: CSI Volumes [Driver: csi-hostpath] [Testpattern: Dynamic PV (default fs)] subPath should support existing directory 10m32s
flakes a lot, do we have an issue open for it?

@msau42
Copy link
Member Author

msau42 commented Nov 30, 2018

Opened #71578 for the flake

@msau42
Copy link
Member Author

msau42 commented Nov 30, 2018

/test pull-kubernetes-integration

@msau42
Copy link
Member Author

msau42 commented Nov 30, 2018

/retest

1 similar comment
@msau42
Copy link
Member Author

msau42 commented Nov 30, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@msau42
Copy link
Member Author

msau42 commented Nov 30, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0955c93 into kubernetes:master Nov 30, 2018
@msau42 msau42 mentioned this pull request Dec 4, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
@k8s-ci-robot
Merge pull request #71681 from msau42/automated-cherry-pick-of-#70756-#…
c213003 
…71625-upstream-release-1.13

Automated cherry pick of #70756: Add e2e test for file exec #71625: Volume exec file test: added NodeSelector to pod
@msau42 msau42 deleted the add-io-exec-test branch March 4, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 davidz627 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@msau42 @k8s-ci-robot @jsafrane @davidz627 @fejta-bot