Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useBetaAPI option from getReplicaZoneURI #70878

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Remove useBetaAPI option from getReplicaZoneURI #70878

merged 1 commit into from
Nov 20, 2018

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Nov 9, 2018

This is a follow up PR for #70716. Remove useBetaAPI option since
Regional PD is already GA.

@jingxu97
Remove useBetaAPI option from getReplicaZoneURI
c5b5f64 
This is a follow up PR for kubernetes#70716. Remove useBetaAPI option since
Regional PD is already GA.
@k8s-ci-robot
Copy link
Contributor

@jingxu97: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2018
@jingxu97 jingxu97 requested review from verult and davidz627 and removed request for gmarek and eparis November 9, 2018 17:48
@jingxu97
Copy link
Contributor Author

jingxu97 commented Nov 9, 2018

cc @davidz627 @verult

@davidz627
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2018
@jingxu97
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@jingxu97 jingxu97 added this to the v1.13 milestone Nov 19, 2018
@jingxu97
Copy link
Contributor Author

cc @davidz627 is this PR blocked to merge?

@davidz627
Copy link
Contributor

I think @saad-ali might need to add some labels

@jingxu97 jingxu97 removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 19, 2018
@nikopen
Copy link
Contributor

nikopen commented Nov 20, 2018

/kind bug
/priority critical-urgent

/cc @saad-ali

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 20, 2018
@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 20, 2018
@nikopen
Copy link
Contributor

nikopen commented Nov 20, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

@jingxu97: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration c5b5f64 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 514a5b8 into kubernetes:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verult verult Awaiting requested review from verult

@davidz627 davidz627 Awaiting requested review from davidz627

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jingxu97 @k8s-ci-robot @davidz627 @nikopen