Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Regional PD to GA #70716

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Move Regional PD to GA #70716

merged 1 commit into from
Nov 9, 2018

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Nov 6, 2018 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
Move GCERegionalPersistentDisk feature to GA

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #59988

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

GCERegionalPersistentDisk feature is GA now!

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 6, 2018
@jingxu97
Copy link
Contributor Author

jingxu97 commented Nov 6, 2018

cc @saad-ali @verult @davidz627

davidz627
davidz627 reviewed Nov 6, 2018
View reviewed changes
pkg/features/kube_features.go Outdated
@@ -276,7 +276,7 @@ const (
CRIContainerLogRotation utilfeature.Feature = "CRIContainerLogRotation"

// owner: @verult
// beta: v1.10
// GA: v1.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this version be updated for GA

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

verult
verult reviewed Nov 6, 2018
View reviewed changes
Copy link
Contributor

@verult verult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: gen.go and gen_test.go are both automatically generated.

pkg/cloudprovider/providers/gce/gce_disks_test.go

manager.createDiskCalled = true
diskTypeURI := gceComputeAPIEndpoint + "projects/" + fmt.Sprintf(diskTypeURITemplateRegional, manager.gceProjectID, manager.gceRegion, diskType)
switch t := manager.targetAPI; t {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that all calls to the GCE PD API are GA, can we remove the checks for other versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to remove the switch block entirely?

@jingxu97
Copy link
Contributor Author

jingxu97 commented Nov 7, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@jingxu97
Copy link
Contributor Author

jingxu97 commented Nov 7, 2018

/test pull-kubernetes-e2e-kops-aws

@jingxu97
Copy link
Contributor Author

jingxu97 commented Nov 7, 2018

@davidz @verult comments are addressed. PTAL

@davidz627
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2018
@saad-ali
Copy link
Member

saad-ali commented Nov 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2018
@davidz627
Copy link
Contributor

/kind feature
/sig storage

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 8, 2018
@davidz627
Copy link
Contributor

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8c2509d into kubernetes:master Nov 9, 2018
jingxu97 added a commit to jingxu97/kubernetes that referenced this pull request Nov 9, 2018
@jingxu97
Remove useBetaAPI option from getReplicaZoneURI
c5b5f64 
This is a follow up PR for kubernetes#70716. Remove useBetaAPI option since
Regional PD is already GA.
@jingxu97 jingxu97 mentioned this pull request Nov 9, 2018
Merged
@AishSundar AishSundar mentioned this pull request Nov 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verult verult verult left review comments

@davidz627 davidz627 davidz627 left review comments

@markturansky markturansky Awaiting requested review from markturansky

@thockin thockin Awaiting requested review from thockin

Assignees

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jingxu97 @davidz627 @saad-ali @k8s-ci-robot @fejta-bot @verult