Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CSI Spec to 1.0.0 and gRPC to 1.13.0 #71020

Merged
merged 4 commits into from
Nov 16, 2018
Merged

Bump CSI Spec to 1.0.0 and gRPC to 1.13.0 #71020

merged 4 commits into from
Nov 16, 2018

Conversation

saad-ali
Copy link
Member

@saad-ali saad-ali commented Nov 14, 2018 •
edited

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR picks up CSI spec v1.0.0

It also bumps the gRPC version since that is out of date.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes/enhancements#178

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Kubernetes v1.13 moves support for Container Storage Interface to GA. As part of this move Kubernetes now supports CSI v1.0.0 and drops support for CSI 0.3 and older releases. Older CSI drivers must be updated to CSI 1.0 in order to work with Kubernetes 1.13+.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 14, 2018
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 14, 2018
@saad-ali saad-ali mentioned this pull request Nov 14, 2018
Closed
@saad-ali
Copy link
Member Author

CSI Tests will fail until the drivers have been updated to pick up 1.0.0.

@AishSundar
Copy link
Contributor

@saad-ali how much delta time window are we looking between bumping CSI Spec to 1.0.0 and updating the drivers? Could you please ping this issue when everything is updated and CSI tests are expected to pass again?

@jberkus @mariantalla @mortent as FYI on upcoming CSI test failures in CI signal

@AishSundar
Copy link
Contributor

/milestone v1.13
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 14, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 14, 2018
@saad-ali
Copy link
Member Author

@saad-ali how much delta time window are we looking between bumping CSI Spec to 1.0.0 and updating the drivers? Could you please ping this issue when everything is updated and CSI tests are expected to pass again?

We're planning to update the drivers Wed. Will keep this issue updated.

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 14, 2018
@msau42
Copy link
Member

msau42 commented Nov 14, 2018

FYI csi tests are run as part of pull now so we cannot merge this PR until all CI drivers are updated. Also we will run the non pull csi tests (serial, slow, alpha) to minimize the possibility of test breakage post merge.

@saad-ali
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-verify

@saad-ali saad-ali mentioned this pull request Nov 14, 2018
Merged
@saad-ali
Copy link
Member Author

/assign @thockin
To unblock approvals while we work on the CSI E2E tests fixes

@davidz627 davidz627 mentioned this pull request Nov 14, 2018
Merged
@thockin
Copy link
Member

thockin commented Nov 14, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2018
davidz627
davidz627 reviewed Nov 15, 2018
View reviewed changes
test/e2e/testing-manifests/storage-csi/hostpath/hostpath/csi-hostpathplugin.yaml
@@ -15,7 +15,7 @@ spec:
hostNetwork: true
containers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line: https://github.com/kubernetes/kubernetes/blob/519eee70ed7fbdaa41dc730c644ca019e508ab86/test/e2e/testing-manifests/storage-csi/hostpath/hostpath/csi-hostpathplugin.yaml#L14

might need to get changed to csi-node-sa based on the other changes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@saad-ali
Copy link
Member Author

We're waiting for the external containers to be published to gcr.io/ so we can update the E2E tests to point to them. Then this PR should be good to merge. Everything else is done.

@AishSundar
Copy link
Contributor

@saad-ali is there a link to the PR to update the e2e test endpoints? And is there an ETA to when this is likely to merge?

@saad-ali
Copy link
Member Author

No other PR, I will just push an update to this PR pointing to the new containers. Should be done in the next hour or two.

@saad-ali
Copy link
Member Author

Ok, all good to go.

@msau42
Copy link
Member

msau42 commented Nov 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@saad-ali
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 16, 2018
@AishSundar
Copy link
Contributor

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@k8s-ci-robot k8s-ci-robot merged commit 6fc6042 into kubernetes:master Nov 16, 2018
@davidz627 davidz627 mentioned this pull request Nov 16, 2018
Closed
@msau42 msau42 mentioned this pull request Nov 19, 2018
Closed
@saad-ali saad-ali mentioned this pull request Nov 21, 2018
Merged
@liggitt liggitt mentioned this pull request Dec 3, 2018
Merged
@liggitt liggitt mentioned this pull request Dec 27, 2018
Closed
@dims dims mentioned this pull request Jan 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 davidz627 left review comments

@pohly pohly pohly requested changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@thockin thockin

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

Out-of-tree CSI Volume Plugins
8 participants
@saad-ali @AishSundar @msau42 @thockin @k8s-ci-robot @fedebongio @pohly @davidz627